Re: Problem compiling glob.c with MinGW

2018-05-12 Thread Eli Zaretskii
> From: Bruno Haible > Cc: bug-gnulib@gnu.org, tim.rueh...@gmx.de > Date: Sat, 12 May 2018 17:13:21 +0200 > > Eli Zaretskii wrote: > > Would it be okay to use 'unsigned' instead of 'uint8_t' on all > > platforms? > > Yes, this is a good idea. Done: Thank you.

Re: Problem compiling glob.c with MinGW

2018-05-12 Thread Bruno Haible
Eli Zaretskii wrote: > Would it be okay to use 'unsigned' instead of 'uint8_t' on all > platforms? Yes, this is a good idea. Done: 2018-05-12 Bruno Haible glob: Choose 'dirent_type' in a way that works better on mingw. Reported and suggested by Eli Zaretskii . * lib/g

Re: Problem compiling glob.c with MinGW

2018-05-12 Thread Eli Zaretskii
> From: Bruno Haible > Cc: Eli Zaretskii , Tim Rühsen > Date: Sat, 12 May 2018 14:59:43 +0200 > > The warning is harmless. But if some day the DT_* values get to get actually > used, there is a bug here. I acknowledge there is a problem. > > However, 'typeof' works only GNU or GNU-compatible co

Re: Problem compiling glob.c with MinGW

2018-05-12 Thread Eli Zaretskii
> From: Bruno Haible > Cc: Tim Rühsen > Date: Sat, 12 May 2018 14:18:36 +0200 > > >CC glob.lo > > glob.c: In function 'glob_in_dir': > > glob.c:1331:32: warning: case label value exceeds maximum value for > > type > > case DT_DIR: case DT_LNK: case DT

Re: Problem compiling glob.c with MinGW

2018-05-12 Thread Bruno Haible
The warning is harmless. But if some day the DT_* values get to get actually used, there is a bug here. I acknowledge there is a problem. However, 'typeof' works only GNU or GNU-compatible compilers. Whereas d_type exists on many platforms (Linux, macOS, FreeBSD, NetBSD, OpenBSD, Cygwin, Android),

Re: Problem compiling glob.c with MinGW

2018-05-12 Thread Bruno Haible
Eli Zaretskii wrote: > Building the latest pretest of wget2 on MinGW produces the following > warning: > >CC glob.lo > glob.c: In function 'glob_in_dir': > glob.c:1331:32: warning: case label value exceeds maximum value for type > case DT_DIR: case DT_

Problem compiling glob.c with MinGW

2018-05-12 Thread Eli Zaretskii
Building the latest pretest of wget2 on MinGW produces the following warning: CC glob.lo glob.c: In function 'glob_in_dir': glob.c:1331:32: warning: case label value exceeds maximum value for type case DT_DIR: case DT_LNK: case DT_UNKNOWN: break;