Re: Patch 2/3 for topic/libposix

2010-11-12 Thread Bruce Korb
On 11/11/10 17:23, Eric Blake wrote: > It's nice to provide a ChangeLog entry, either as a patch to ChangeLog > itself or as the commit message (or both; if you use Jim's vc-dwim pacage). True, hadn't dotted my "i"s nor crossed my "t"s yet. >> /* The calling program should define program_name an

Re: Patch 2/3 for topic/libposix

2010-11-11 Thread Bruno Haible
Bruce Korb wrote: > This patch modifies lib/error.c so that should someone > call it without having set program_name, then a message > is printed and abort() called instead of seg faulting. A link error would be best, to detect this situation. If we cannot get a link error, an abort() is a small i

Re: Patch 2/3 for topic/libposix

2010-11-11 Thread Paul Eggert
On 11/11/2010 05:09 PM, Bruce Korb wrote: > This patch modifies lib/error.c so that should someone > call it without having set program_name, then a message > is printed and abort() called instead of seg faulting. It's not clear that this is a win. The current code, in glibc and in most other C l

Re: Patch 2/3 for topic/libposix

2010-11-11 Thread Eric Blake
On 11/11/2010 06:09 PM, Bruce Korb wrote: > This patch modifies lib/error.c so that should someone > call it without having set program_name, then a message > is printed and abort() called instead of seg faulting. > Subject: [PATCH 2/3] give a sensible error message when error() is called > witho

Patch 2/3 for topic/libposix

2010-11-11 Thread Bruce Korb
This patch modifies lib/error.c so that should someone call it without having set program_name, then a message is printed and abort() called instead of seg faulting. >From 70e49cdeba9becf444c6b6a6c6bd74e8fe6b80e4 Mon Sep 17 00:00:00 2001 From: Bruce Korb Date: Thu, 11 Nov 2010 08:46:00 -0800 Subje