On Tue, Mar 14, 2017 at 11:28 AM, Mathieu Lirzin wrote:
...
> Here is an updated patch with a rationale in the ChangeLog:
>
> Thanks for the review (to both of you).
Thank you. I've pushed that.
Hi,
Bruno Haible writes:
> Mathieu Lirzin wrote:
>> Here is the patch:
>
> Given the code from gnulib-tool that you are removing, I think:
>
>> +EXTRA_DIST += top/GNUmakefile
>
> This should read
>
>EXTRA_DIST += $(top_srcdir)/GNUmakefile
>
>> +EXTRA_DIST += top/maint.mk
>
> This should read
On Tue, Mar 14, 2017 at 10:34 AM, Bruno Haible wrote:
> Mathieu Lirzin wrote:
>> Here is the patch:
>
> Given the code from gnulib-tool that you are removing, I think:
>
>> +EXTRA_DIST += top/GNUmakefile
>
> This should read
>
>EXTRA_DIST += $(top_srcdir)/GNUmakefile
>
>> +EXTRA_DIST += top/ma
Mathieu Lirzin wrote:
> Here is the patch:
Given the code from gnulib-tool that you are removing, I think:
> +EXTRA_DIST += top/GNUmakefile
This should read
EXTRA_DIST += $(top_srcdir)/GNUmakefile
> +EXTRA_DIST += top/maint.mk
This should read
EXTRA_DIST += $(top_srcdir)/maint.mk
othe
gt;>>> --8<---cut here---start->8---
>>>>> if test -n "$top_files"; then
>>>>> sed_prepend_topdir='s,^,$(top_srcdir)/,'
>>>>> echo "EXTRA_DIST += "`echo "$top_fi
s"; then
>>>> sed_prepend_topdir='s,^,$(top_srcdir)/,'
>>>> echo "EXTRA_DIST += "`echo "$top_files" | sed -e
>>>> "$sed_prepend_topdir"`
>>>> echo
>>>> fi
>>&g
f test -n "$top_files"; then
>>>> sed_prepend_topdir='s,^,$(top_srcdir)/,'
>>>> echo "EXTRA_DIST += "`echo "$top_files" | sed -e
>>>> "$sed_prepend_topdir"`
>>>> echo
>>>
^,$(top_srcdir)/,'
>>> echo "EXTRA_DIST += "`echo "$top_files" | sed -e
>>> "$sed_prepend_topdir"`
>>> echo
>>> fi
>>> --8<---cut here---end--->8---
>>>
>>
prepend_topdir"`
>> echo
>> fi
>> --8<---cut here---end--->8---
>>
>> IMO we should move the responsability of distributing "top/*" files to
>> the module definition instead, and not distributing &quo
--end------->8---
>
> IMO we should move the responsability of distributing "top/*" files to
> the module definition instead, and not distributing "README-release"
> automatically (like what is done in Coreutils).
>
> What do people
)/,'
echo "EXTRA_DIST += "`echo "$top_files" | sed -e "$sed_prepend_topdir"`
echo
fi
--8<---cut here---end--->8---
IMO we should move the responsability of distributing "top/*" files to
the module definitio
11 matches
Mail list logo