Eric Blake byu.net> writes:
> always report ASSERT failures to the original stderr,
> regardless of what the test did to fd 2.
Well, it would work if mingw's dup2 weren't broken. On mingw, dup2 always
returns 0 for success, rather than the fd just opened.
> + /* We might close fd 2 later, so
Eric Blake wrote:
> ... rearranging calls in the parent to avoid deadlock ...
Thanks! This possible deadlock was so easy to overlook.
Bruno
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 7/19/2009 4:53 AM:
> I've committed this. The test now passes on mingw (and of course also on
> Linux and Cygwin).
I'm committing this followup, which fixes a comment rendered stale by your
previous commit, adds the same c
Eric Blake wrote:
> The test is still buggy on mingw; here's a followup for the test to at
> least let it compile, and I'm still investigating why the test fails on
> mingw (but it looks like the problem is in:
>
> 156 orig_stdin = dup_noinherit (STDIN_FILENO);
> (gdb) n
> (null): _open_osfh
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 7/18/2009 10:00 AM:
> Eric Blake wrote:
>> It is due to a bug in gnulib.
>
> Yup. Thanks for committing the test and the fix.
The test is still buggy on mingw; here's a followup for the test to at
least let it compile, an
Eric Blake wrote:
> It is due to a bug in gnulib.
Yup. Thanks for committing the test and the fix.
> | if (pipe_stdin)
> |if (pipe (ofd) < 0
> ||| (ofd[1] = fd_safer (ofd[1])) < 0)
>
> This has the effect of setting ofd to {1,5} if exactly one of stdin/stdout
> were
> closed.
Ind
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 7/17/2009 6:14 AM:
> According to Akim Demaille on 7/15/2009 6:44 AM:
>> I have tried to write a small test case for gnulib (made to be
>> eventually included there, at least it would be a useful sample). It
>> shows the sam
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 7/18/2009 7:50 AM:
> Hi Akim,
>
>> We, at Bison Corp., have some bug occurring on Tru64
>> (http://lists.gnu.org/archive/html/bug-bison/2009-06/msg4.html
>> ) that seems to be related with our piping into GNU M4. Bi
Hi Akim,
> We, at Bison Corp., have some bug occurring on Tru64
> (http://lists.gnu.org/archive/html/bug-bison/2009-06/msg4.html
> ) that seems to be related with our piping into GNU M4. Bison
> basically reads its input, feeds m4 with various files, and "parses"
> the output of m4 befo
Eric Blake byu.net> writes:
> but I think the simplest is just replacing the existing two calls
> to pipe/fd_safer with the simpler one-line call to pipe_safer. I'll commit a
> patch later today, which also adds a pipe-test module using your test-pipe.c
> as a starting point (but avoiding the
Akim Demaille lrde.epita.fr> writes:
> Reading the code, I don't see why the child should be affected here,
> but it is.
It is due to a bug in gnulib.
| if (pipe_stdin)
|if (pipe (ofd) < 0
||| (ofd[1] = fd_safer (ofd[1])) < 0)
This has the effect of setting ofd to {1,5} if exact
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 7/17/2009 6:25 AM:
> make: *** No rule to make target `spawn.h', needed by `all'. Stop.
>
> In lib/gnulib.mk, I see lines like:
>
> BUILT_SOURCES += $(SPAWN_H)
> BUILT_SOURCES += $(STDBOOL_H)
>
> In the corresponding Make
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 7/17/2009 6:14 AM:
>> The attempt to use create-pipe-bidi is pushed in Bison's branch
>> candidates/create-pipe-bidi, if some wants to play with it. The test
>> case is compiled as src/test-pipe.
>
> I'll try and find some
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Akim Demaille on 7/15/2009 6:44 AM:
> I have tried to write a small test case for gnulib (made to be
> eventually included there, at least it would be a useful sample). It
> shows the same problem, although somewhat differently.
It's a n
Hi gnuliebers,
First a disclaimer: I'm far from being fluent with fd business, I'm
probably asking newbie questions...
We, at Bison Corp., have some bug occurring on Tru64 (http://lists.gnu.org/archive/html/bug-bison/2009-06/msg4.html
) that seems to be related with our piping into GNU M
15 matches
Mail list logo
