Re: [patch] glob. If pattern has a trailing slash match directories only

Good morning. On Mon, Nov 18, 2019 at 1:05 AM Paul Eggert wrote: > Did you intend to attach a new version of the patch > to the above-quoted email, or was that email merely commenting on the patch > you > sent on November 12 > ? i inten

Re: [patch] glob. If pattern has a trailing slash match directories only

On 11/17/19 6:03 PM, Dmitry Goncharov wrote: This version of the same patch covers GLOB_NOCHECK and GLOB_NOMAGIC better for the trailing slash case and also fixes glob ("", GLOB_NOMAGIC, ...) case. Sorry, I don't quite follow. Did you intend to attach a new version of the patch to the above-qu

Re: [patch] glob. If pattern has a trailing slash match directories only

Good morning. On Tue, Nov 12, 2019 at 8:44 PM Dmitry Goncharov wrote: > On Sun, Nov 10, 2019 at 6:15 PM Paul Eggert wrote: > > It seems to me that the performance issues are still there, in the sense > > that if > > GLOB_ONLYDIR is set then 'glob' now does a stat call on each directory > > ent

Re: [patch] glob. If pattern has a trailing slash match directories only

Good morning. On Sun, Nov 10, 2019 at 6:15 PM Paul Eggert wrote: > It seems to me that the performance issues are still there, in the sense that > if > GLOB_ONLYDIR is set then 'glob' now does a stat call on each directory entry > to > see whether it's a directory. The idea is that this patch

Re: [patch] glob. If pattern has a trailing slash match directories only

On 11/10/19 9:17 AM, Dmitry Goncharov via Gnulib discussion list wrote: On Sat, Nov 9, 2019 at 8:13 PM Bruno Haible wrote: Are these issues supposed to be fixed in the new patch? yes. It seems to me that the performance issues are still there, in the sense that if GLOB_ONLYDIR is set then

Re: [patch] glob. If pattern has a trailing slash match directories only

Good morning. On Sat, Nov 9, 2019 at 8:13 PM Bruno Haible wrote: > Are these issues supposed to be fixed in the new patch? yes. > (I appreciate that you add tests!): It is easier to write a test program than to test glob manually. > - Please follow GNU coding style, esp. regarding space bet

Re: [patch] glob. If pattern has a trailing slash match directories only

Hi Dmitry, > The original version of this patch was discussed here > https://sourceware.org/ml/libc-alpha/2017-11/msg00983.html. When I read this mail thread, the status was that not all issues raised by Paul were resolved, in particular the performance regression. Are these issues supposed to be

[patch] glob. If pattern has a trailing slash match directories only

Good morning. If pattern has a trailing slash match directories only. This patch also makes glob return directories and symlinks to directories only when GLOB_ONLYDIR is specified. The original version of this patch was discussed here https://sourceware.org/ml/libc-alpha/2017-11/msg00983.html. Tes