Re: [patch] (but not for gnulib) squash git diff spurious exit code 1

2008-01-02 Thread Thien-Thi Nguyen
() Jim Meyering <[EMAIL PROTECTED]> () Fri, 28 Dec 2007 22:41:37 +0100 I've adapted your patch to apply to the trunk. New one below. It looks like you may want to adjust it further, so that "git diff-index..." with neither --stat option also exits successfully. Do you feel like

Re: [patch] (but not for gnulib) squash git diff spurious exit code 1

2007-12-28 Thread Jim Meyering
Thien-Thi Nguyen <[EMAIL PROTECTED]> wrote: > () Jim Meyering <[EMAIL PROTECTED]> > () Thu, 27 Dec 2007 22:13:53 +0100 > >[test case?] > > thanks for looking into this. ... > try --stat > try --shortstat I've adapted your patch to apply to the trunk. New one below. It looks like you may

Re: [patch] (but not for gnulib) squash git diff spurious exit code 1

2007-12-27 Thread Thien-Thi Nguyen
() Ben Pfaff <[EMAIL PROTECTED]> () Thu, 27 Dec 2007 14:46:26 -0800 As a workaround, you can run git-status before git-diff. This is semi-documented in the documentation for git-status: If any paths have been touched in the working tree (that is, their modification time

Re: [patch] (but not for gnulib) squash git diff spurious exit code 1

2007-12-27 Thread Ben Pfaff
Thien-Thi Nguyen <[EMAIL PROTECTED]> writes: > below is a script (write to /tmp/z ; chmod +x) that shows little output > and exit code 0 with the patch and spurious "0 files changed" and exit > code 1 without. i am curious how it behaves w/ other versions of git. As a workaround, you can run git

Re: [patch] (but not for gnulib) squash git diff spurious exit code 1

2007-12-27 Thread Thien-Thi Nguyen
below is an updated patch. it skips all output, instead of just the stats, for this special case. thi _ * diff.c (CHANGE_MIND_LAST_MOMENT_MAYBE): New macro. (show_stats): Use it immediately prior to output. (show_shortstats):

Re: [patch] (but not for gnulib) squash git diff spurious exit code 1

2007-12-27 Thread Thien-Thi Nguyen
() Jim Meyering <[EMAIL PROTECTED]> () Thu, 27 Dec 2007 22:13:53 +0100 [test case?] thanks for looking into this. below is a script (write to /tmp/z ; chmod +x) that shows little output and exit code 0 with the patch and spurious "0 files changed" and exit code 1 without. i am curious how it

Re: [patch] (but not for gnulib) squash git diff spurious exit code 1

2007-12-27 Thread Jim Meyering
Thien-Thi Nguyen <[EMAIL PROTECTED]> wrote: > then i remembered, it was gnulib denizens. ah, justice! so, in the > spirit of sharing around, instead of through, the tree trunk, i post > this here in hopes that it will be useful to git users, and that perhaps > one of them may muster the patience

[patch] (but not for gnulib) squash git diff spurious exit code 1

2007-12-27 Thread Thien-Thi Nguyen
first off, apologies to anyone offended by my sending a patch for git to this mailing list. clearly offtopic. but maybe not completely. please allow this brief explanation: i remember faintly someone talking about "git diff" (and brethren) returning non-zero spuriously even when there were no di