Re: [libvirt] namespace clean shared libraries

2012-08-02 Thread Daniel P. Berrange
On Thu, Aug 02, 2012 at 03:14:27PM +0200, Wido den Hollander wrote: > On 08/02/2012 01:37 PM, Daniel P. Berrange wrote: > >On Thu, Aug 02, 2012 at 01:18:12PM +0200, Wido den Hollander wrote: > >>On 07/08/2012 07:51 PM, Bruno Haible wrote: > >>>Daniel P. Berrange wrote: > If its better to just d

Re: [libvirt] namespace clean shared libraries

2012-08-02 Thread Wido den Hollander
On 08/02/2012 01:37 PM, Daniel P. Berrange wrote: On Thu, Aug 02, 2012 at 01:18:12PM +0200, Wido den Hollander wrote: On 07/08/2012 07:51 PM, Bruno Haible wrote: Daniel P. Berrange wrote: If its better to just do it in libvirt config.h, then we can do that too Yes, doing '#define foo libvirt

Re: [libvirt] namespace clean shared libraries

2012-08-02 Thread Bruno Haible
Daniel P. Berrange wrote: > Try applying this patch to your source tree > > diff --git a/configure.ac b/configure.ac > index 6b189db..4f906bb 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2876,6 +2876,10 @@ test "x$lv_cv_static_analysis" = xyes && t=1 > AC_DEFINE_UNQUOTED([STATIC_ANALYSI

Re: [libvirt] namespace clean shared libraries

2012-08-02 Thread Daniel P. Berrange
On Thu, Aug 02, 2012 at 01:18:12PM +0200, Wido den Hollander wrote: > On 07/08/2012 07:51 PM, Bruno Haible wrote: > >Daniel P. Berrange wrote: > >>If its better to just do it in libvirt config.h, then we > >>can do that too > > > >Yes, doing '#define foo libvirt_foo' in config.h is the preferred wa

Re: [libvirt] namespace clean shared libraries

2012-08-02 Thread Wido den Hollander
On 07/08/2012 07:51 PM, Bruno Haible wrote: Daniel P. Berrange wrote: If its better to just do it in libvirt config.h, then we can do that too Yes, doing '#define foo libvirt_foo' in config.h is the preferred way of achieving a namespace clean shared library. There are two ways to generate th

Re: [libvirt] namespace clean shared libraries

2012-07-08 Thread Bruno Haible
Daniel P. Berrange wrote: > If its better to just do it in libvirt config.h, then we > can do that too Yes, doing '#define foo libvirt_foo' in config.h is the preferred way of achieving a namespace clean shared library. There are two ways to generate these #defines: 1) You collect manually, on v