Re: [gawk-devel] changing regex lib

2018-08-11 Thread Paul Eggert
Bruno Haible wrote: Therefore I would rewrite the comment /* Convert the byte B to the corresponding wide character. In a unibyte locale, treat B as itself. In a multibyte locale, return WEOF if B is an encoding error. */ to /* Convert the byte B to a value that bounds the iterati

Re: [gawk-devel] changing regex lib

2018-08-11 Thread arnold
Paul Eggert wrote: > arn...@skeeve.com wrote: > > I tried out Paul's change and it works for me. > > Thanks for checking. I installed the regcomp.c change into glibc and gnulib > so > we should now have the same source there as we have in Gawk. Thanks Paul! I will likely merge that into the g

Re: [gawk-devel] changing regex lib

2018-08-10 Thread Bruno Haible
Hi Paul, > Thanks for checking. I installed the regcomp.c change into glibc and gnulib > so > we should now have the same source there as we have in Gawk. The patch [1] looks correct to me, but it introduces a misleading comment that could become the cause of future bugs. Recall that for argum

Re: [gawk-devel] changing regex lib

2018-08-10 Thread Paul Eggert
arn...@skeeve.com wrote: I tried out Paul's change and it works for me. Thanks for checking. I installed the regcomp.c change into glibc and gnulib so we should now have the same source there as we have in Gawk.