Re: [bug-gnulib] proposed 'string' module for gnulib

2007-01-27 Thread Bruno Haible
Paul Eggert wrote: > * m4/memmem.m4 (gl_FUNC_MEMMEM): Set HAVE_DECL_MEMMEM if necessary. > * m4/mempcpy.m4 (gl_FUNC_MEMPCPY): Set HAVE_MEMPCPY if necessary. > ... Some ordering constraint is missing here. We have to guarantee that the HAVE_DECL_MEMMEM=1 statement occurs after the

Re: [bug-gnulib] proposed 'string' module for gnulib

2007-01-27 Thread Bruno Haible
Paul Eggert wrote: > Here's what I actually installed. Additionally, I change the copyright dates to include the years of the files that were merged into lib/string_.h. Also I prefer to use 'extern' - for clarity, and because it makes the declarations stand out better in an editor with syntax colo

Re: [bug-gnulib] proposed 'string' module for gnulib

2007-01-26 Thread Bruno Haible
Hi Paul, Thanks for the huge work! Your ChangeLog entry doesn't mark strndup.h, strnlen.h, strpbrk.h, strsep.h, strstr.h, strtok_r.h as removed. Presumably you want to remove them as well? In lib/canon-host.c, I'd vote for #including before the gnulib specific headers ("getaddrinfo.h" etc.). I