Re: [RFT] Wrap winsock functions for improved compatibility

2008-09-13 Thread Bruno Haible
Paolo Bonzini wrote: > ReadFile and WriteFile work under win32 with sockets (learning that is > what prompted me to submit this finally). Terrific!! With this, we can completely emulate the POSIX socket APIs. Bruno

Re: [RFT] Wrap winsock functions for improved compatibility

2008-09-12 Thread Paolo Bonzini
> First round of cygwin 1.5.x results (I ran out of time to investigate any > further at the moment, and I also haven't had time to do cygwin 1.7.0 tests): > > Pipe test... failed (expecting POLLHUP after shutdown) > FAIL: test-poll.exe Good, this also gives a baseline for the native poll implemen

Re: [RFT] Wrap winsock functions for improved compatibility

2008-09-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 9/12/2008 7:16 AM: >> $ git push [EMAIL PROTECTED]:/srv/git/gnulib/ericb.git +HEAD:mob > > Indeed, you can find it there as f50320c. You can also run test-poll on > the native poll emulation, but I guess I'll have to fin

Re: [RFT] Wrap winsock functions for improved compatibility

2008-09-12 Thread Paolo Bonzini
> Yes, cygwin has a working . Do you have a repository > somewhere that I can pull from to test on cygwin, before this hits the > master gnulib.git on savannah? I'm not going to commit it soon, because it sort-of-breaks the poll emulation. The two should reach savannah together. > For that mat

Re: [RFT] Wrap winsock functions for improved compatibility

2008-09-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 9/12/2008 6:53 AM: >> - > It needs to be tested on Windows (mingw and cygwin) >> >> The patch is supposed to change nothing on Cygwin, right? Cygwin has >> perfectly fine POSIX socket support already. > > I added a #e

Re: [RFT] Wrap winsock functions for improved compatibility

2008-09-12 Thread Paolo Bonzini
> - > It needs to be tested on Windows (mingw and cygwin) > > The patch is supposed to change nothing on Cygwin, right? Cygwin has > perfectly fine POSIX socket support already. I added a #error to verify that. That's why I needed testing on Cygwin. > - The transformation of WSAGetLastErro

Re: [RFT] Wrap winsock functions for improved compatibility

2008-09-12 Thread Bruno Haible
Hi Paolo, This is exciting! By using _open_osfhandle you are ensuring that there are no collisions between native file handles and socket-related file handles. Great! A few comments, though: - > It needs to be tested on Windows (mingw and cygwin) The patch is supposed to change nothing on Cyg

Re: [RFT] Wrap winsock functions for improved compatibility

2008-09-12 Thread Paolo Bonzini
Paolo Bonzini wrote: > Hi all, > > this proposed patch wraps winsock functions that take or return socket > descriptors, so that C run-time library descriptors are used instead. > This should be fully transparent to the user, except that you can close > these sockets with close, read them with rea

[RFT] Wrap winsock functions for improved compatibility

2008-09-12 Thread Paolo Bonzini
Hi all, this proposed patch wraps winsock functions that take or return socket descriptors, so that C run-time library descriptors are used instead. This should be fully transparent to the user, except that you can close these sockets with close, read them with read/write, and so on. The only rem