Re: [bug-libunistring] [PATCH v4] unistr: New modules for backward iteration in string.

2014-09-27 Thread Daiki Ueno
Ben Pfaff writes: >>> Are you going to add "unsafe" version later, or is it not useful at all? >> >> I do not have a use myself for unsafe versions, but I will add them if >> you think they are a good idea. Let me know. > > What is your opinion on this issue? Oh, sorry, it wasn't my intention t

Re: [bug-libunistring] [PATCH v4] unistr: New modules for backward iteration in string.

2014-09-26 Thread Ben Pfaff
On Fri, Sep 19, 2014 at 8:06 AM, Ben Pfaff wrote: > On Fri, Sep 19, 2014 at 04:55:24PM +0900, Daiki Ueno wrote: >> Ben Pfaff writes: >> >> > New module 'unistr/u8-mb-prev-uc'. >> > New module 'unistr/u16-mb-prev-uc'. >> > New module 'unistr/u32-mb-prev-uc'. >> >> Thanks, looks good to me. Some n

Re: [bug-libunistring] [PATCH v4] unistr: New modules for backward iteration in string.

2014-09-19 Thread Ben Pfaff
On Fri, Sep 19, 2014 at 04:55:24PM +0900, Daiki Ueno wrote: > Ben Pfaff writes: > > > New module 'unistr/u8-mb-prev-uc'. > > New module 'unistr/u16-mb-prev-uc'. > > New module 'unistr/u32-mb-prev-uc'. > > Thanks, looks good to me. Some nit-picking below. > > * _GL_UNUSED_PARAMETER of u32_mb_pr

Re: [bug-libunistring] [PATCH v4] unistr: New modules for backward iteration in string.

2014-09-19 Thread Daiki Ueno
Ben Pfaff writes: > New module 'unistr/u8-mb-prev-uc'. > New module 'unistr/u16-mb-prev-uc'. > New module 'unistr/u32-mb-prev-uc'. Thanks, looks good to me. Some nit-picking below. * _GL_UNUSED_PARAMETER of u32_mb_prev_uc seems to be a leftover, as the argument is actually used in the implem

[PATCH v4] unistr: New modules for backward iteration in string.

2014-09-18 Thread Ben Pfaff
New module 'unistr/u8-mb-prev-uc'. * lib/unistr.in.h (u8_mb_prev_uc): New declaration. (u8_mb_prev_uc_aux): New declaration. * lib/unistr/u8-mb-prev-uc.c: New file. * lib/unistr/u8-mb-prev-uc-aux.c: New file. * tests/test-u8-mb-prev-uc.c: New file. * modules/u8-mb-prev-uc: New file. * modules/u8-mb