Re: [PATCH v2] fix not a string literal warning in test_xasprintf

2012-04-22 Thread g . esp
- Mail original - > De: "Bruno Haible" > À: bug-gnulib@gnu.org > Cc: "Gilles Espinasse" > Envoyé: Jeudi 5 Avril 2012 12:32:56 > Objet: Re: [PATCH v2] fix not a string literal warning in test_xasprintf > > Gilles Espinasse wrote: > > Rem

Re: [PATCH v2] fix not a string literal warning in test_xasprintf

2012-04-05 Thread Bruno Haible
More about security warnings and style warnings: > So, the warning "format not a string literal and no format arguments" or, > more generally "format with no format arguments", is a *style* warning, > not a *security* warning. The idea is that security warnings are about situations that are dange

Re: [PATCH v2] fix not a string literal warning in test_xasprintf

2012-04-05 Thread Bruno Haible
Gilles Espinasse wrote: > Remove the code hack preventing format-zero-length warning and replace by a > pragma GCC diagnostic ignored in top of code. This patch is not good, because the warning "zero-length format string" exists at least since GCC 3.1, however '#pragma GCC diagnostic ignored "-Wfo

[PATCH v2] fix not a string literal warning in test_xasprintf

2012-04-02 Thread Gilles Espinasse
With gcc-4.4.5 patched with defaults-format-security.patch, coreutils emit test-xvasprintf.c: In function 'test_xasprintf': test-xvasprintf.c:98: warning: format not a string literal and no format arguments There is a gnulib-tests/Makefile hack preventing the warning in case coreutils is compile