On 03/19/2010 03:07 AM, Simon Josefsson wrote:
> It may be cleanest to split the test modules too, so there is one
> test-forkpty.c and test-openpty.c.
Yeah, I did that in v2 of the patch, which means there are no
dependencies between forkpty and openpty (either one can be used/tested
in isolation
Eric Blake wrote:
> > - Why does 'forkpty' depend on 'openpty'?
>
> I guess it doesn't have to. It's just that for now, test-forkpty.c
> tests both interfaces.
Then it should be 'forkpty-tests' that depends on 'openpty'.
The case where you see a difference is when someone asks for just the
'f
I like these changes -- I think I mentioned that approach earlier when
adding the pty module, but before we had replacement functions for
forkpty/openpty in progress, the separation is kind of unnecessary.
Let's hope we'll have replacement functions soon after this. Feel free
to push your changes.
On 03/18/2010 07:35 PM, Bruno Haible wrote:
> Hi Eric,
>
> You requested a rapid review:
Well, supplying rapid comments saying 'please give me more time' are
also acceptable to slow me down; but I do appreciate the rapid review!
>
> Eric Blake wrote:
>> + AC_SEARCH_LIBS([forkpty], [util libuti
Hi Eric,
You requested a rapid review:
Eric Blake wrote:
> + AC_SEARCH_LIBS([forkpty], [util libutil],
> +[if test "$ac_cv_search_forkpty" != "none required"; then
> + PTY_LIB="$ac_cv_search_forkpty"
> + fi])
The second argument [util libutil] can be simplified to [util], no?
Sear
* modules/pty (Makefile.am): Substitute new witnesses.
(Libraries): Move library detection...
* modules/forkpty: ...into new module.
* modules/openpty: Another new module.
* modules/pty-tests: Rename...
* modules/forkpty-tests: ...to this.
* tests/test-pty.c: Rename...
* tests/test-forkpty.c: ...to
