Re: [PATCH 2/2] file-has-acl: no need for struct stat

2024-10-07 Thread Bruno Haible
> FAIL: test-file-has-acl.sh > == > > file_has_aclinfo failed for "tmpfile0" > file_has_acl("tmpfile0") returned , expected no > FAIL test-file-has-acl.sh (exit status: 1) > > FAIL: test-file-has-acl-1.sh > > > file_has_aclinfo failed for "tmp

Re: [PATCH 2/2] file-has-acl: no need for struct stat

2024-10-07 Thread Bruno Haible
Paul Eggert wrote: > + FLAGS should be a d_type value, optionally ORed with > + AT_SYMLINK_FOLLOW; if the d_type value is not known, This comment got me considering whether that's portable, and it is not: AT_SYMLINK_FOLLOW DT_* glibc/Linux0x400 0 .. 14 musl libc

Re: [PATCH 2/2] file-has-acl: no need for struct stat

2024-10-06 Thread Bruno Haible
The CI reports 3 new test failures on Cygwin. The last CI build at 2024-10-02 07:00 GMT was green. This commit must be the regression's cause. FAIL: test-file-has-acl.sh == file_has_aclinfo failed for "tmpfile0" file_has_acl("tmpfile0") returned , expected no FAIL test-fil

[PATCH 2/2] file-has-acl: no need for struct stat

2024-10-02 Thread Paul Eggert
Change the API of the new file_has_aclinfo function so that it no longer needs a struct stat *. In some cases this can help GNU ls avoid an unnecessary ‘stat’ call for each file it lists, which can be a significant win. * lib/acl.h (ACL_SYMLINK_NOFOLLOW): Change from 1 to UCHAR_MAX+1 so that it ca