Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-17 Thread Paul Eggert
On 2024-08-17 07:54, Bruno Haible wrote: Hi Paul, [2]: https://git.savannah.gnu.org/cgit/m4.git/commit/?h=branch-1.4&id=b357b798b04053df437b2df2f4f42dca69fb764c Thanks. But now, in m4, there is a "make distcheck" failure: ... An update of po/POTFILES.in is in order, I think. Like you did in

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-17 Thread Bruno Haible
Hi Paul, > [2]: > https://git.savannah.gnu.org/cgit/m4.git/commit/?h=branch-1.4&id=b357b798b04053df437b2df2f4f42dca69fb764c Thanks. But now, in m4, there is a "make distcheck" failure: $ make distcheck ... (cd po && make top_distdir=../m4-2021-05-16 distdir=../m4-2021-05-16/po \ am__remo

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-16 Thread Pádraig Brady
On 15/08/2024 23:13, Paul Eggert wrote: Thanks, I installed the attached. Oh it required a change in downstream projects. I assumed it was gnulib specific. Thanks for fixing it in coreutils. Pádraig

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-15 Thread Paul Eggert
On 2024-08-15 03:09, Bruno Haible wrote: Use attribute [[nodiscard]] wherever glibc uses __wur. Should we do the same thing, to mirror glibc attributes in gnulib's function declarations, for all other attributes? I'm inclined to think so, as it gives Gnulib and Gnulib-using packages heads-

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-15 Thread Paul Eggert
Thanks, I installed the attached.From 9e60f2db903b17c1a31e24b89bda90a12446459d Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 15 Aug 2024 15:12:25 -0700 Subject: [PATCH] maint: adjust to recent removal of verror.c * po/POTFILES.in: Remove lib/verror.c --- po/POTFILES.in | 1 - 1 file cha

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-15 Thread Pádraig Brady
On 15/08/2024 02:05, Paul Eggert wrote: delete mode 100644 lib/verror.c From coreutils CI: make[3]: *** No rule to make target '../lib/verror.c', needed by 'coreutils.pot-update'. thanks, Pádraig

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-15 Thread Bruno Haible
Paul Eggert wrote: > I didn't find it simple in this case. ... > > This is my usual experience, to be honest. I try to copy from existing > decls but I usually get it wrong. In this case, it was because you wanted to tell the compiler's control flow analysis about the STATUS != 0 case. This is v

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-15 Thread Paul Eggert
On 2024-08-15 00:05, Bruno Haible wrote: Declaring Gnulib functions in general is just a matter of copying the same idiom that we have in hundreds of places in *.in.h files. Its history and genesis is not simple; but the result is simple to apply. I didn't find it simple in this case. For exam

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-15 Thread Bruno Haible
Paul Eggert wrote: > Thanks, I attempted to fix that by installing the attached. Thanks; I confirm it fixes the issue. > I wish I didn't have to remember the > complicated rules for declaring Gnulib functions, and to some extent > this simplistic patch is a perhaps-vain attempt to cut down on t

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-14 Thread Paul Eggert
Thanks, I attempted to fix that by installing the attached. It attempts to be simple rather than catering to fancy warnings even in the situation you mention. I wish I didn't have to remember the complicated rules for declaring Gnulib functions, and to some extent this simplistic patch is a pe

Re: [PATCH 2/2] error: merge from glibc and with verror

2024-08-14 Thread Bruno Haible
Paul Eggert wrote: > (verror, verror_at_line): New decls and macros. This patch breaks the ability to do library-namespacing of these symbols. How to reproduce: 1. Create a testdir of module 'verror'. 2. Configure it. 3. Append to config.h the definitions: #define verror libfoo_verror #de

[PATCH 2/2] error: merge from glibc and with verror

2024-08-14 Thread Paul Eggert
* lib/error.c: Merge changes since 2018 from glibc. - The following changes are taken from glibc: (__error_internal, __error_at_line_internal): New functions, with most of the old error and error_at_line_internal but with va_list and with a new trailing mode_args, for wide character mode. (erro