RE: bug#9141: [PATCH 1/3] extensions: Enable extensions on MacOS X 10.5 and later.

2011-07-24 Thread Voelker, Bernhard
Paul Eggert wrote: > On 07/24/11 22:59, Voelker, Bernhard wrote: > >>> #ifndef _ALL_SOURCE >>> # undef _ALL_SOURCE >>> #endif >>> +/* Enable general extensions on MacOS X. */ >>> +#ifndef _DARWIN_C_SOURCE >>> +# undef _DARWIN_C_SOURCE >>> +#endif >> >> maybe it's too early in the morning for

Re: bug#9141: [PATCH 1/3] extensions: Enable extensions on MacOS X 10.5 and later.

2011-07-24 Thread Paul Eggert
On 07/24/11 22:59, Voelker, Bernhard wrote: >> #ifndef _ALL_SOURCE >> # undef _ALL_SOURCE >> #endif >> +/* Enable general extensions on MacOS X. */ >> +#ifndef _DARWIN_C_SOURCE >> +# undef _DARWIN_C_SOURCE >> +#endif > > maybe it's too early in the morning for me ... but isn't this a NOP: > "

RE: bug#9141: [PATCH 1/3] extensions: Enable extensions on MacOS X 10.5 and later.

2011-07-24 Thread Voelker, Bernhard
Paul Eggert wrote: > diff --git a/m4/extensions.m4 b/m4/extensions.m4 > index 1330503..22156e0 100644 > --- a/m4/extensions.m4 > +++ b/m4/extensions.m4 > @@ -1,4 +1,4 @@ > -# serial 9 -*- Autoconf -*- > +# serial 10 -*- Autoconf -*- > # Enable extensions on systems that normally disable them. >

Re: bug#9141: [PATCH 1/3] extensions: Enable extensions on MacOS X 10.5 and later.

2011-07-23 Thread Paul Eggert
On 07/22/11 17:23, Bruno Haible wrote: > The usual idiom in the MacOS X header files is > > #if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE) > > So, I expect that your change will be a no-op for almost everyone. Thanks for the clarification. I looked through what I could glean from

Re: [PATCH 1/3] extensions: Enable extensions on MacOS X 10.5 and later.

2011-07-22 Thread Bruno Haible
Paul Eggert wrote: > Recent versions of MacOS seem to have a _DARWIN_C_SOURCE flag that > has roughly the same role that _GNU_SOURCE has for GNU systems. It's not "roughly the same". _GNU_SOURCE makes some symbols visible that are not visible by default. Whereas _DARWIN_C_SOURCE makes some symbols

[PATCH 1/3] extensions: Enable extensions on MacOS X 10.5 and later.

2011-07-22 Thread Paul Eggert
Recent versions of MacOS seem to have a _DARWIN_C_SOURCE flag that has roughly the same role that _GNU_SOURCE has for GNU systems. I pushed the following patch into gnulib, under the theory that it is more in the line with the usual Autoconf / gnulib philosophy, and it may fix some porting issues.