Re: [PATCH 07/10] regex: fix longstanding backref match bug

2021-04-16 Thread Dmitry V. Levin
On Fri, Feb 05, 2021 at 05:25:59PM -0800, Paul Eggert wrote: > This fixes a longstanding glibc bug concerning backreferences > (2009-12-04). Nit: this short URL doesn't work, while the longer one does: https://sourceware.org/bugzilla/show_bug.cgi?id=11053 > * lib/re

Re: [PATCH 07/10] regex: fix longstanding backref match bug

2021-02-09 Thread Paul Eggert
On 2/9/21 11:42 AM, Adhemerval Zanella wrote: Trying to sync gnulib with glibc code, this patch trigger some regression on glibc testcases: Thanks for letting me know. That's odd, as I didn't find any regressions when I synced. I do know of remaining bugs and will add these to my list.

Re: [PATCH 07/10] regex: fix longstanding backref match bug

2021-02-09 Thread Adhemerval Zanella
Hi Paul, Trying to sync gnulib with glibc code, this patch trigger some regression on glibc testcases: FAIL: posix/tst-boost FAIL: posix/tst-pcre FAIL: posix/tst-rxspencer FAIL: posix/tst-rxspencer-no-utf8 $ grep -n "FAIL rm" posix/tst-boost.out 445:FAIL rm[1] 3..-1 != expected 2..3 448:FAIL rm[

[PATCH 07/10] regex: fix longstanding backref match bug

2021-02-05 Thread Paul Eggert
This fixes a longstanding glibc bug concerning backreferences (2009-12-04). * lib/regexec.c (proceed_next_node, push_fail_stack) (pop_fail_stack): Push and pop the previous registers as well as the current ones. All callers changed. (set_regs): Also pop if CUR_NODE h