Re: [PATCH 00/11] Android compatibility

2015-02-17 Thread Kevin Cernekee
On Tue, Feb 17, 2015 at 10:07 PM, Paul Eggert wrote: > Kevin Cernekee wrote: test-localename is calling strdup() on a NULL pointer returned by >>gl_locale_name_thread(), and crashing. From reading >>gl_locale_name_thread() it seems like NULL is a valid result. Maybe >> w

Re: [PATCH 00/11] Android compatibility

2015-02-17 Thread Paul Eggert
Kevin Cernekee wrote: test-localename is calling strdup() on a NULL pointer returned by >>gl_locale_name_thread(), and crashing. From reading >>gl_locale_name_thread() it seems like NULL is a valid result. Maybe we >>need to change the test case to "return 77" on systems that are unaware >>of l

Re: [PATCH 00/11] Android compatibility

2015-02-11 Thread Kevin Cernekee
On Wed, Feb 11, 2015 at 4:12 PM, Paul Eggert wrote: > Thanks for doing all that work! I pushed the first 10 patches and have > a couple of comments. I'll send a separate email about the 11th patch. > > Kevin Cernekee wrote: > >> FAIL: test-verify.sh >> >> >> compiler didn't

Re: [PATCH 00/11] Android compatibility

2015-02-11 Thread Paul Eggert
Thanks for doing all that work! I pushed the first 10 patches and have a couple of comments. I'll send a separate email about the 11th patch. Kevin Cernekee wrote: FAIL: test-verify.sh compiler didn't detect verification failure 1 ... test-verify is trying to perform com

[PATCH 00/11] Android compatibility

2015-02-11 Thread Kevin Cernekee
This patch series fixes several build failures and test failures seen when compiling gnulib with Bionic libc (Android NDK r10d). With these patches applied, I was able to compile each module listed by "gnulib-tool --list" except for gnumakefile and non-recursive-gnulib-prefix-hack, for ARM (32-bit