Re: [PATCH] time: work with mingw + pthreads-win32 library

Eric Blake wrote: > Yes, looks reasonable Thanks for the review. Pushed it. Bruno

Re: [PATCH] time: work with mingw + pthreads-win32 library

On 06/03/2010 03:57 AM, Bruno Haible wrote: > Hi Eric, > >> # if ! @TIME_H_DEFINES_STRUCT_TIMESPEC@ >> # if @SYS_TIME_H_DEFINES_STRUCT_TIMESPEC@ >> # include >> +# elif @PTHREAD_H_DEFINES_STRUCT_TIMESPEC@ >> +# include >> # else > > Now, gnulib - not the user's code - is including th

Re: [PATCH] time: work with mingw + pthreads-win32 library

Hi Eric, > # if ! @TIME_H_DEFINES_STRUCT_TIMESPEC@ > # if @SYS_TIME_H_DEFINES_STRUCT_TIMESPEC@ > # include > +# elif @PTHREAD_H_DEFINES_STRUCT_TIMESPEC@ > +# include > # else Now, gnulib - not the user's code - is including this , of which you just determined that it contains a broke

[PATCH] time: work with mingw + pthreads-win32 library

When using the pthreads-win32 library with mingw, struct timespec is available in . Meanwhile, that header has some rather buggy macros for localtime_r and gmtime_r that interfere with proper gnulib replacement header actions. Tested in a cross-compilation environment: Fedora 13 with mingw32-gcc