Re: [PATCH] tests: fix test-execute with GNU make jobserver

On Thu, Apr 08, 2021 at 01:44:35AM +0200, Bruno Haible wrote: [...] > I'm applying this fix: > > > 2021-04-07 Bruno Haible > > execute tests: Avoid test failure in certain environments. > Reported by Dmitry V. Levin in >

Re: [PATCH] tests: fix test-execute with GNU make jobserver

Hi Dmitry, > Yes, it is reliable as it mirrors > for (fd = 0; fd < 20; fd++) > piece of code in tests/test-execute-child.c file. Ah, I had missed that. Thanks. > there could > be other external sources of inherited descriptors, so the test should > rather be robust and make sure these exte

Re: [PATCH] tests: fix test-execute with GNU make jobserver

Hi Bruno, On Wed, Apr 07, 2021 at 11:30:47PM +0200, Bruno Haible wrote: > Hi Dmitry, > > Thanks for the proposed patch. > > > On POSIX systems the GNU make jobserver is implemented as a pipe, > > and these two unexpected descriptors make test-execute-child fail. > > This problem description is

Re: [PATCH] tests: fix test-execute with GNU make jobserver

Hi Dmitry, Thanks for the proposed patch. > On POSIX systems the GNU make jobserver is implemented as a pipe, > and these two unexpected descriptors make test-execute-child fail. This problem description is a bit technical. It took me a bit of work to translate your description into a "how to re

[PATCH] tests: fix test-execute with GNU make jobserver

On POSIX systems the GNU make jobserver is implemented as a pipe, and these two unexpected descriptors make test-execute-child fail. Workaround this by making all unexpected descriptors cloexec in test-execute-main so they are not inherited by test-execute-child. * tests/test-execute-main.c (cloe