Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 2/13/2010 7:55 AM: >>> For negated character classes in shell case statements, POSIX says to use >>> [!a-z], not [^a-z]. >> >> I've made that change, too. >> Does it matter in practice? > > It matters for at least Solaris /bin/sh. > > $ /bin/sh -c '

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Eric Blake
According to Jim Meyering on 2/13/2010 7:55 AM: >> For negated character classes in shell case statements, POSIX says to use >> [!a-z], not [^a-z]. > > I've made that change, too. > Does it matter in practice? It matters for at least Solaris /bin/sh. $ /bin/sh -c 'case a in [^b]) echo yes;; *) e

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 2/13/2010 4:51 AM: >> Review/comments appreciated. Thanks for the prompt review! >> +# Given a directory name, DIR, if every entry in it that matches *.exe >> +# contains only the specified bytes (see the case stmt below), then print >> +# a space-

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Eric Blake
According to Jim Meyering on 2/13/2010 4:51 AM: > Review/comments appreciated. > > +# Given a directory name, DIR, if every entry in it that matches *.exe > +# contains only the specified bytes (see the case stmt below), then print > +# a space-separated list of those names and return 0. Otherwis

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-02-13 Thread Jim Meyering
Jim Meyering wrote: > Eric Blake wrote: >> According to Jim Meyering on 1/14/2010 1:08 AM: >>> Think of a set-up function that (when $EXEEXT is nonempty) >>> iterates through the *.$EXEEXT executables in a specified directory... >>> >>> create_exe_shim_functions () >>> { >>> case $EXEEXT in >>>

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-16 Thread Ralf Wildenhues
Hello, * Eric Blake wrote on Thu, Jan 14, 2010 at 02:31:17PM CET: > According to Jim Meyering on 1/14/2010 1:08 AM: > > Think of a set-up function that (when $EXEEXT is nonempty) > > iterates through the *.$EXEEXT executables in a specified directory... > > > > create_exe_shim_functions () > > {

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-14 Thread Eric Blake
According to Jim Meyering on 1/14/2010 6:46 AM: >> Or go one step further, do the search for *.exe without regards to >> $EXEEXT, skipping this case block, and simplifying modules/*-tests. > > I like the idea of not having to modify all modules/*-tests, but have > two reservations: > - I like ha

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-14 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 1/14/2010 1:08 AM: >> Think of a set-up function that (when $EXEEXT is nonempty) >> iterates through the *.$EXEEXT executables in a specified directory... >> >> create_exe_shim_functions () >> { >> case $EXEEXT in >> '') return 0 ;; >> .exe

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-14 Thread Eric Blake
According to Jim Meyering on 1/14/2010 1:08 AM: > Think of a set-up function that (when $EXEEXT is nonempty) > iterates through the *.$EXEEXT executables in a specified directory... > > create_exe_shim_functions () > { > case $EXEEXT in > '') return 0 ;; > .exe) ;; > *) echo "$0: une

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-14 Thread Simon Josefsson
Jim Meyering writes: > create_exe_shim_functions () I like it! Thanks, /Simon

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-14 Thread Jim Meyering
Jim Meyering wrote: > Eric Blake wrote: >> According to Jim Meyering on 1/13/2010 3:19 AM: >>> I didn't account for that use case. >>> I wonder if there is some way to write/use a command-not-found >>> handler to automate the error-prone "add-$EXE-suffix" at run-time. >>> >>> If at all possible, I

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-13 Thread Simon Josefsson
Jim Meyering writes: > I wonder if there is some way to write/use a command-not-found > handler to automate the error-prone "add-$EXE-suffix" at run-time. We could create a macro in init.sh that needs to be used when invoking a program, but I think it would be as error-prone as $EXEEXT (it needs

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-13 Thread Bruno Haible
Eric Blake wrote: > BeOS requires the .exe suffix. No, on BeOS there is no problem: EXEEXT is empty there. > Wine is another case where the suffix is (currently) important. Then let's add the extension. It's an idiom that is not difficult to follow: 1. use ${EXEEXT} when executing a compiled p

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-13 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 1/13/2010 3:19 AM: >> I didn't account for that use case. >> I wonder if there is some way to write/use a command-not-found >> handler to automate the error-prone "add-$EXE-suffix" at run-time. >> >> If at all possible, I would like to avoid the inv

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-13 Thread Eric Blake
According to Jim Meyering on 1/13/2010 3:19 AM: > I didn't account for that use case. > I wonder if there is some way to write/use a command-not-found > handler to automate the error-prone "add-$EXE-suffix" at run-time. > > If at all possible, I would like to avoid the invasive change > of adding

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-13 Thread Jim Meyering
Simon Josefsson wrote: > Bruno Haible writes: >> Simon Josefsson wrote: >>> diff --git a/tests/test-xalloc-die.sh b/tests/test-xalloc-die.sh >>> index 03bad60..80d6208 100755 >>> --- a/tests/test-xalloc-die.sh >>> +++ b/tests/test-xalloc-die.sh >>> @@ -18,7 +18,7 @@ >>> >>> . "${srcdir=.}/init.sh

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-13 Thread Simon Josefsson
Bruno Haible writes: > Simon Josefsson wrote: >> diff --git a/tests/test-xalloc-die.sh b/tests/test-xalloc-die.sh >> index 03bad60..80d6208 100755 >> --- a/tests/test-xalloc-die.sh >> +++ b/tests/test-xalloc-die.sh >> @@ -18,7 +18,7 @@ >> >> . "${srcdir=.}/init.sh"; path_prepend_ . >> >> -te

Re: [PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-12 Thread Bruno Haible
Simon Josefsson wrote: > diff --git a/tests/test-xalloc-die.sh b/tests/test-xalloc-die.sh > index 03bad60..80d6208 100755 > --- a/tests/test-xalloc-die.sh > +++ b/tests/test-xalloc-die.sh > @@ -18,7 +18,7 @@ > > . "${srcdir=.}/init.sh"; path_prepend_ . > > -test-xalloc-die 2> err > out > +test

[PATCH] tests/test-xalloc-die.sh: Use $EXEEXT.

2010-01-12 Thread Simon Josefsson
Pushed. /Simon --- ChangeLog|4 tests/test-xalloc-die.sh |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index fac2f33..7e9fc3e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,8 @@ 2010-01-12 Simon Josefsson + +