Re: [PATCH] test-canonicalize: avoid a build failure

2020-02-10 Thread Bruno Haible
> * tests/test-canonicalize.c: Protect the inclusion of null-ptr.h > with the same guard as that used to protect usage of the null_ptr > function The same thing is needed in test-ptsname_r.c: 2020-02-10 Bruno Haible ptsname_r-tests: Avoid unused function warning. * tests/test

Re: [PATCH] test-canonicalize: avoid a build failure

2020-02-03 Thread Bruno Haible
> + * tests/test-canonicalize.c: Protect the inclusion of null-ptr.h > + with the same guard as that used to protect usage of the null_ptr > + function The patch is OK. However, I would appreciate if you don't call a warning a "build failure" or an "error". Reasons: 1. Adding -Wer

[PATCH] test-canonicalize: avoid a build failure

2020-02-03 Thread Pádraig Brady
* tests/test-canonicalize.c: Protect the inclusion of null-ptr.h with the same guard as that used to protect usage of the null_ptr function, so that one doesn't get a -Werror=unused build failure, warning about the function being defined but unused. * tests/test-canonicalize-lgpl.c: Likewise. ---