Re: [PATCH] strerror_r: avoid clobbering strerror on cygwin

2011-05-21 Thread Eric Blake
On 05/21/2011 10:15 AM, Eric Blake wrote: > Avoid cygwin strerror_r, since it clobbers strerror buffer through > cygwin 1.7.9. __xpg_strerror_r is okay, but if a program is > compiled on cygwin 1.7.8 or earlier, it is not available. Aargh. __xpg_strerror_r is _not_ okay, until the upcoming cygwi

Re: [PATCH] strerror_r: avoid clobbering strerror on cygwin

2011-05-21 Thread Eric Blake
On 05/21/2011 12:27 PM, Bruno Haible wrote: > Eric Blake wrote: >> Avoid cygwin strerror_r, since it clobbers strerror buffer through >> cygwin 1.7.9. __xpg_strerror_r is okay, but if a program is >> compiled on cygwin 1.7.8 or earlier, it is not available. >> >> * lib/strerror_r.c (strerror_r): D

Re: [PATCH] strerror_r: avoid clobbering strerror on cygwin

2011-05-21 Thread Bruno Haible
Eric Blake wrote: > Avoid cygwin strerror_r, since it clobbers strerror buffer through > cygwin 1.7.9. __xpg_strerror_r is okay, but if a program is > compiled on cygwin 1.7.8 or earlier, it is not available. > > * lib/strerror_r.c (strerror_r): Don't use cygwin's strerror_r; > fall back instead

[PATCH] strerror_r: avoid clobbering strerror on cygwin

2011-05-21 Thread Eric Blake
Avoid cygwin strerror_r, since it clobbers strerror buffer through cygwin 1.7.9. __xpg_strerror_r is okay, but if a program is compiled on cygwin 1.7.8 or earlier, it is not available. * lib/strerror_r.c (strerror_r): Don't use cygwin's strerror_r; fall back instead to sys_errlist. * modules/stre