Re: [PATCH] socklen: do not depend on sys_socket

Hi Paul, > Here's the revised proposed patch. OK, this is now easier to review, now that the unrelated hunks have been committed separately. > > #include > > #if HAVE_SYS_SOCKET_H > > #include > > #endif > > Given the changes you proposed in the other part of your comment,

Re: [PATCH] socklen: do not depend on sys_socket

Thanks for looking into this, Bruno. I altered the patch to reflect your comments, with the following further ideas: On 03/19/2011 06:49 AM, Bruno Haible wrote: >the 'Include' statement of the socklen module should be changed ... to > > #include > #if HAVE_SYS_SOCKET_H > #inc

Re: [PATCH] socklen: do not depend on sys_socket

Hi Paul, > * m4/socklen.m4 (gl_PREREQ_TYPE_SOCKLEN_T): New macro, taken from > parts of gl_PREREQ_SYS_H_SOCKET. > (gl_TYPE_SOCKLEN_T): Require it instead of requiring > gl_PREREQ_SYS_H_SOCKET. Check for ws2tcpip.h only if > sys_socket is also used. > * m4/sys_socket_h.m4 (gl_PREREQ_SYS_H_SOCKET):

Re: [PATCH] socklen: do not depend on sys_socket

Paul Eggert wrote: > +   * modules/inet_ntop (Depends-on): Remove socklen, since > +   sys_socket is supposed to provide socklen_t and we already > +   depend on sys_socket. > +   * modules/inet_pton, modules/netdb: Likewise. This part is undoubtedly correct, after we document that

Re: [PATCH] socklen: do not depend on sys_socket

On 03/17/2011 08:29 PM, Bruno Haible wrote: >> Emacs is not intended to be portable to MingW and Cygwin. > Huh? How does this statement match the "GNU Emacs FAQ For MS Windows" [1], > section 2.4? Ah, sorry, I was mistaken. I don't understand how Emacs is built on MS-DOS or MS-Windows (nor do I u

Re: [PATCH] socklen: do not depend on sys_socket

Paul Eggert wrote: > Emacs is not intended to be portable to MingW and Cygwin. Huh? How does this statement match the "GNU Emacs FAQ For MS Windows" [1], section 2.4? Bruno [1] http://www.gnu.org/software/emacs/windows/faq.html -- In memoriam Matthias Kraus

[PATCH] socklen: do not depend on sys_socket

Here's another Emacs-related patch I'm proposing for gnulib to break an unnecessary dependency, in this case a circular one. While trying to modify Emacs to use gnulib's socklen module, I discovered a circular dependency: socklen depends on sys_socket and vice versa. Emacs can use socklen,