Re: [PATCH] signed integer overflow undefined behavior

2013-12-13 Thread Paul Eggert
On 12/12/2013 10:12 PM, Eric Lubin wrote: > he disregards the fact that integer overflow is undefined in C No, it's listed in FIXME comments: /* FIXME: Check for arithmetic overflow in all cases, not just some of them. */ ... /* FIXME: It also assumes that signed integer overflow silently wrap

[PATCH] signed integer overflow undefined behavior

2013-12-13 Thread Eric Lubin
From 1a52c994df8ca00fb22c8d3be9860f3996c83440 Mon Sep 17 00:00:00 2001 From: Eric Lubin Date: Thu, 12 Dec 2013 21:47:21 -0800 Subject: [PATCH 1/1] Fixed undefined integer overflow checks that were being optimized out by the compiler The code in question shows that the developer clearly spent som