Re: [PATCH] regex: fix match with possessive quantifier

2021-06-22 Thread Egor Ignatov
> regex_internal.c:1317:7: runtime error: execution reached an unreachable > program point > FAIL test-regex (exit status: 1) This problem occurs in this test: '{ "()\\1*\\1*", "", REG_EXTENDED, 2, { { 0, 0 }, { 0, 0 } } }' because proceed_next_node tries to insert an existing element into the se

Re: [PATCH] regex: fix match with possessive quantifier

2021-06-21 Thread Paul Eggert
On 6/6/21 2:45 PM, Dmitry V. Levin wrote: I've applied it now, and the following follow-up patch: These recently-installed patches fail for me, which indicates that the patches aren't correct. Could you please fix this? The test failure is causing 'make check' to fail for GNU grep. I tested

Re: [PATCH] regex: fix match with possessive quantifier

2021-06-16 Thread Dmitry V. Levin
On Mon, Jun 07, 2021 at 04:10:27AM +0300, Dmitry V. Levin wrote: > On Mon, Jun 07, 2021 at 12:45:02AM +0300, Dmitry V. Levin wrote: > > On Wed, May 26, 2021 at 12:08:19PM +0300, Egor Ignatov wrote: > > > Fix behaviour introduced in 70b673e, where regexps with > > > possessive quantifier("*+") didn'

Re: [PATCH] regex: fix match with possessive quantifier

2021-06-06 Thread Dmitry V. Levin
On Mon, Jun 07, 2021 at 12:45:02AM +0300, Dmitry V. Levin wrote: > On Wed, May 26, 2021 at 12:08:19PM +0300, Egor Ignatov wrote: > > Fix behaviour introduced in 70b673e, where regexps with > > possessive quantifier("*+") didn't match. > > * lib/regexec.c > > (set_regs): Pop if CUR_NODE has already

Re: [PATCH] regex: fix match with possessive quantifier

2021-06-06 Thread Dmitry V. Levin
On Wed, May 26, 2021 at 12:08:19PM +0300, Egor Ignatov wrote: > Fix behaviour introduced in 70b673e, where regexps with > possessive quantifier("*+") didn't match. > * lib/regexec.c > (set_regs): Pop if CUR_NODE has already been checked only when > we have a fail stack. > > Signed-off-by: Egor Ign

[PATCH] regex: fix match with possessive quantifier

2021-05-26 Thread Egor Ignatov
Fix behaviour introduced in 70b673e, where regexps with possessive quantifier("*+") didn't match. * lib/regexec.c (set_regs): Pop if CUR_NODE has already been checked only when we have a fail stack. Signed-off-by: Egor Ignatov --- Hi Paul, Do you have any test cases for bug 11053(glibc) for gnul