Re: [PATCH] realloc: fix undef typo

2021-04-11 Thread Bruno Haible
Hi Paul, > > The patch above has the effect that libunistring.so will now export > > 'realloc'. Which is not right. > > OK, but why doesn't a similar problem happen with malloc and calloc? > lib/malloc.c has "#undef malloc", and similarly for lib/calloc.c. It surely happens for 'malloc' and 'ca

Re: [PATCH] realloc: fix undef typo

2021-04-11 Thread Paul Eggert
On 4/10/21 3:22 PM, Bruno Haible wrote: The patch above has the effect that libunistring.so will now export 'realloc'. Which is not right. OK, but why doesn't a similar problem happen with malloc and calloc? lib/malloc.c has "#undef malloc", and similarly for lib/calloc.c. I doubt there are

Re: [PATCH] realloc: fix undef typo

2021-04-10 Thread Bruno Haible
Hi Paul, > diff --git a/lib/realloc.c b/lib/realloc.c > index 51d8d2108..ab027d7f7 100644 > --- a/lib/realloc.c > +++ b/lib/realloc.c > @@ -24,6 +24,7 @@ > /* Only the AC_FUNC_REALLOC macro defines 'realloc' already in config.h. */ > #ifdef realloc > # define NEED_REALLOC_GNU 1 > +# undef real

[PATCH] realloc: fix undef typo

2021-04-10 Thread Paul Eggert
* lib/realloc.c: #undef realloc if config.h defines it. This fixes a typo that I introduced in 2011-04-08T18:39:01Z!egg...@cs.ucla.edu. Apparently nobody uses Gnulib realloc in that way? --- ChangeLog | 8 lib/realloc.c | 1 + 2 files changed, 9 insertions(+) diff --git a/ChangeLog b