Re: [PATCH] quotearg: avoid uninitialized variable use

2011-04-29 Thread Eric Blake
On 04/29/2011 10:55 AM, Jim Meyering wrote: >> When custom_quoting_style was introduced in commit 12247f77, >> this method was not updated, so any caller that passed >> the new enum value to any of the existing quotearg_*style >> functions could trigger a crash from the uninitialized memory. >> Tha

Re: [PATCH] quotearg: avoid uninitialized variable use

2011-04-29 Thread Jim Meyering
Eric Blake wrote: > Coverity correctly deduced: > > Error: UNINIT: > m4-1.4.16/lib/quotearg.c:171: var_decl: Declaring variable "o" without > initializer. > m4-1.4.16/lib/quotearg.c:175: uninit_use: Using uninitialized value "o": > field "o".right_quote is uninitialized. > > When custom_quoting_s

[PATCH] quotearg: avoid uninitialized variable use

2011-04-28 Thread Eric Blake
Coverity correctly deduced: Error: UNINIT: m4-1.4.16/lib/quotearg.c:171: var_decl: Declaring variable "o" without initializer. m4-1.4.16/lib/quotearg.c:175: uninit_use: Using uninitialized value "o": field "o".right_quote is uninitialized. When custom_quoting_style was introduced in commit 1224