Re: [PATCH] parse-datetime: pacify gcc 14 -Wformat-security

2025-01-05 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > No, and thanks that looks good. OK. Pushed.

Re: [PATCH] parse-datetime: pacify gcc 14 -Wformat-security

2025-01-05 Thread Paul Eggert
On 2025-01-05 15:10, Bruno Haible wrote: Any objections to fixing it like in the attached proposed patch? No, and thanks that looks good.

Re: [PATCH] parse-datetime: pacify gcc 14 -Wformat-security

2025-01-05 Thread Bruno Haible via Gnulib discussion list
Hi Paul, Reviewing parse-datetime.y, I see that * 6 invocations of dbg_fputs don't use _(), while the others do. * The invocations of _() inside dbg_printf and dbg_fputs is useless, because at this point in the code the argument is not a string literal, thus 'xgettext' will not extract

[PATCH] parse-datetime: pacify gcc 14 -Wformat-security

2025-01-05 Thread Paul Eggert
I found this when updating GNU patch. * lib/parse-datetime.y (dbg_herald): New static function. (dbg_printf): Use it. (dbg_fputs): New static function. All dbg_printf callers changed to use it, if their formats contain no directives. (parse_datetime_body): Call fputs instead of fprintf if either w