Hi Paolo,
> AC_CHECK_FUNCS_ONCE should _always_ expand to an empty string. The
> test is done always---and it is done outside the macro.
Then the test of $HAVE_LANGINFO_H = 1 can go away as well: It was meant
to save some configure execution time by not checking for nl_langinfo
when does not e
Ralf Wildenhues wrote:
> * Jim Meyering wrote on Tue, Jan 05, 2010 at 07:09:57PM CET:
>> Paolo Bonzini wrote:
>> > On 01/04/2010 03:03 PM, Jim Meyering wrote:
>> >> However, it would be far better if AC_CHECK_FUNCS_ONCE
>> >> were to expand to e.g., ":" rather than the empty string,
>> >> so that i
Hello,
* Jim Meyering wrote on Tue, Jan 05, 2010 at 07:09:57PM CET:
> Paolo Bonzini wrote:
> > On 01/04/2010 03:03 PM, Jim Meyering wrote:
> >> However, it would be far better if AC_CHECK_FUNCS_ONCE
> >> were to expand to e.g., ":" rather than the empty string,
> >> so that it can be used unadorne
Paolo Bonzini wrote:
> On 01/04/2010 03:03 PM, Jim Meyering wrote:
>> Testing my proposed make-regex-use-nl_langinfo changes,
>> I encountered this configure failure:
>> ...
>> checking whether is self-contained... yes
>> ./configure: line 31968: syntax error near unexpected token `
On 01/04/2010 03:03 PM, Jim Meyering wrote:
Testing my proposed make-regex-use-nl_langinfo changes,
I encountered this configure failure:
...
checking whether is self-contained... yes
./configure: line 31968: syntax error near unexpected token `else'
./configure: line 31968:
Jim Meyering wrote:
> Bruno, ok to apply?
> ...
> @@ -10,6 +10,7 @@ AC_DEFUN([gl_FUNC_NL_LANGINFO],
>AC_REQUIRE([gl_LANGINFO_H])
>if test $HAVE_LANGINFO_H = 1; then
> AC_CHECK_FUNCS_ONCE([nl_langinfo])
> +: # in case AC_CHECK_FUNCS_ONCE expands to nothing
>else
> ac_cv_fun
the above.
Otherwise, it looks like a pitfall designed to trap the uninitiated.
Bruno, ok to apply?
>From 9e02cb5888ff492d260536803ed9c96e1ef7b7e5 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 4 Jan 2010 14:59:04 +0100
Subject: [PATCH] nl_langinfo: avoid configure-time synta
