Re: [PATCH] memset_explicit: port to older MS-Windows

2022-12-26 Thread Paul Eggert
On 12/26/22 08:50, Bruno Haible wrote: For compilers other than GCC and clang, we are betting on a trick with 'volatile'. I'm not sure it won't break in the future. But at least for now, with MSVC, the unit tests still pass. Thanks for doing the unit tests. Yes, the hope is that this good is go

Re: [PATCH] memset_explicit: port to older MS-Windows

2022-12-26 Thread Bruno Haible
Paul Eggert wrote: > * lib/memset_explicit.c (memset_explicit): > Remove special case for C==0 and MS-Windows. The code isn’t > needed for correctness > ... > /* Set S's bytes to C, where S has LEN bytes. The compiler will not > optimize effects away, even if S is dead after the call. */ >

[PATCH] memset_explicit: port to older MS-Windows

2022-12-17 Thread Paul Eggert
* lib/memset_explicit.c (memset_explicit): Remove special case for C==0 and MS-Windows. The code isn’t needed for correctness and it’s more trouble than it’s worth as it prevents this module from being used with GNU Emacs, which wants to port to MS-Windows versions so old that they lack SecureZero