Re: [PATCH] maint.mk: syntax-check: prohibit HAVE__H that are always true

2010-04-27 Thread Jim Meyering
Pádraig Brady wrote: > On 27/04/10 13:15, Jim Meyering wrote: >> I've just pushed the patch below. >> It exposed a few unnecessary #if tests in coreutils: > > Very nice check. Thanks. >> Hence the compromise of searching for all of them at once, >> with the downside that occasionally you'll be wa

Re: [PATCH] maint.mk: syntax-check: prohibit HAVE__H that are always true

2010-04-27 Thread Pádraig Brady
On 27/04/10 13:15, Jim Meyering wrote: > I've just pushed the patch below. > It exposed a few unnecessary #if tests in coreutils: Very nice check. > Hence the compromise of searching for all of them at once, > with the downside that occasionally you'll be warned about > a line like this one (from

[PATCH] maint.mk: syntax-check: prohibit HAVE__H that are always true

2010-04-27 Thread Jim Meyering
19:07:57 +0200 Subject: [PATCH] maint.mk: syntax-check: prohibit HAVE__H that are always true Derive the list of guaranteed header names from gnulib/lib/*.in.h, and use that to create a regexp used to detect all #if HAVE_..._H uses. * top/maint.mk (sc_prohibit_always_true_header_tes