Re: [PATCH] maint.mk: improve the public-submodule-commit rule

2011-01-21 Thread Eric Blake
On 01/20/2011 04:34 AM, Jim Meyering wrote: > So far, I don't see a down-side to adding this line to maint.mk: > > check: public-submodule-commit > > Does anyone else? Yes, but only minor: > public-submodule-commit: > - if test -d $(srcdir)/.git; then \ >

Re: [PATCH] maint.mk: improve the public-submodule-commit rule

2011-01-21 Thread Jim Meyering
Eric Blake wrote: > On 01/20/2011 04:34 AM, Jim Meyering wrote: >> This is in preparation for hooking this rule to "check" >> at least in coreutils. Today I was burned once again by >> pushing a non-public submodule reference (coreutils). >> The fact that this check is currently run only at relea

Re: [PATCH] maint.mk: improve the public-submodule-commit rule

2011-01-20 Thread Eric Blake
On 01/20/2011 04:34 AM, Jim Meyering wrote: > This is in preparation for hooking this rule to "check" > at least in coreutils. Today I was burned once again by > pushing a non-public submodule reference (coreutils). > The fact that this check is currently run only at release time > is good, but ob

[PATCH] maint.mk: improve the public-submodule-commit rule

2011-01-20 Thread Jim Meyering
Jan 2011 11:50:53 +0100 Subject: [PATCH] maint.mk: improve the public-submodule-commit rule * top/maint.mk (public-submodule-commit): Prefix with $(AM_V_GEN), to suppress printing of its commands... unless V=1. Add git submodule's --quiet option to suppress printing of e.g., "Enteri