Re: [PATCH] maint.mk: add a syntax-check rule to ensure tightly-scoped symbols

2011-05-18 Thread Jim Meyering
Pádraig Brady wrote: > On 17/05/11 15:23, Pádraig Brady wrote: >> Given '^__.*' names are reserved by the compiler, >> perhaps the happy medium is to to allow single underscores, >> but exclude double underscores, with something like: > > I'm going with the following, so as to not put the > onus on

Re: [PATCH] maint.mk: add a syntax-check rule to ensure tightly-scoped symbols

2011-05-17 Thread Pádraig Brady
On 17/05/11 15:23, Pádraig Brady wrote: > Given '^__.*' names are reserved by the compiler, > perhaps the happy medium is to to allow single underscores, > but exclude double underscores, with something like: I'm going with the following, so as to not put the onus on users configuring an exclude l

Re: [PATCH] maint.mk: add a syntax-check rule to ensure tightly-scoped symbols

2011-05-17 Thread Pádraig Brady
On 17/05/11 15:08, Jim Meyering wrote: > Pádraig Brady wrote: >> On 09/05/11 11:44, Jim Meyering wrote: >>> I've been using a precursor of this rule in coreutils for many years, >> >>> so finally have made it general enough so that the same >> >> The above change is giving a false positive on my 32

Re: [PATCH] maint.mk: add a syntax-check rule to ensure tightly-scoped symbols

2011-05-17 Thread Jim Meyering
Pádraig Brady wrote: > On 09/05/11 11:44, Jim Meyering wrote: >> I've been using a precursor of this rule in coreutils for many years, > >> so finally have made it general enough so that the same > > The above change is giving a false positive on my 32 linux laptop, > where it flags __i686.get_pc_

Re: [PATCH] maint.mk: add a syntax-check rule to ensure tightly-scoped symbols

2011-05-17 Thread Pádraig Brady
On 09/05/11 11:44, Jim Meyering wrote: > I've been using a precursor of this rule in coreutils for many years, > so finally have made it general enough so that the same The above change is giving a false positive on my 32 linux laptop, where it flags __i686.get_pc_thunk.bx from src/libstdbuf_so-

[PATCH] maint.mk: add a syntax-check rule to ensure tightly-scoped symbols

2011-05-09 Thread Jim Meyering
dda1748375671 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 9 May 2011 12:30:55 +0200 Subject: [PATCH] maint.mk: add a syntax-check rule to ensure tightly-scoped symbols * top/maint.mk (sc_tight_scope): New rule. (sc_tight_scope-0): New rule, ifdef'd out. (_gl_TS_dir): D