Re: [PATCH] hash: extend module to deal with non-pointer keys

2010-07-04 Thread Jim Meyering
Pádraig Brady wrote: > On 02/07/10 20:17, Jim Meyering wrote: >> Thanks again for the report. >> However, while I was able to reproduce it (on Paul's system) >> and debug it, it appears to be due to a miscompilation of di-set.o >> when using a private copy of gcc-4.5.0. When I recompiled >> that o

Re: [PATCH] hash: extend module to deal with non-pointer keys

2010-07-04 Thread Pádraig Brady
On 02/07/10 20:17, Jim Meyering wrote: > Thanks again for the report. > However, while I was able to reproduce it (on Paul's system) > and debug it, it appears to be due to a miscompilation of di-set.o > when using a private copy of gcc-4.5.0. When I recompiled > that one file with gcc-Ubuntu 4.4.

Re: [PATCH] hash: extend module to deal with non-pointer keys

2010-07-02 Thread Jim Meyering
Paul Eggert wrote: > On 07/01/10 15:59, Jim Meyering wrote: > >> Can you give me a backtrace? >> Even if your patch is clearly better, I'd like to know >> how my code is malfunctioning. > > Sure. This uses your older patch, not the newer gnulib one. > > Program received signal SIGABRT, Aborted. >

Re: [PATCH] hash: extend module to deal with non-pointer keys

2010-07-02 Thread Jim Meyering
Paul Eggert wrote: > On 07/01/10 15:59, Jim Meyering wrote: > >> Can you give me a backtrace? >> Even if your patch is clearly better, I'd like to know >> how my code is malfunctioning. > > Sure. This uses your older patch, not the newer gnulib one. I think they're functionally equivalent. The n

Re: [PATCH] hash: extend module to deal with non-pointer keys

2010-07-01 Thread Paul Eggert
On 07/01/10 15:59, Jim Meyering wrote: > Can you give me a backtrace? > Even if your patch is clearly better, I'd like to know > how my code is malfunctioning. Sure. This uses your older patch, not the newer gnulib one. Program received signal SIGABRT, Aborted. 0x0012d422 in __kernel_vsyscall (

Re: [PATCH] hash: extend module to deal with non-pointer keys

2010-07-01 Thread Jim Meyering
Paul Eggert wrote: > Re the patch you just reported in: > > > I assume this is to support the du performance improvement that was proposed > in > . Right. That's the same as this: http://

Re: [PATCH] hash: extend module to deal with non-pointer keys

2010-07-01 Thread Paul Eggert
Re the patch you just reported in: I assume this is to support the du performance improvement that was proposed in . I see that you incorporated a further improvement in the gnulib patch,

[PATCH] hash: extend module to deal with non-pointer keys

2010-07-01 Thread Jim Meyering
directly in gnulib. >From 5bef1a3537bd22cd8be2bdd4053be617a07b64f1 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 1 Jul 2010 23:17:25 +0200 Subject: [PATCH] hash: extend module to deal with non-pointer keys * lib/hash.c (hash_insert0): New interface, much like hash_insert but that all