Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-24 Thread Bruno Haible
Hi Collin, > Can you apply this patch for me? Thanks, applied, with a tweak: I don't like the variable name 'group' here. I know that 'tuple' is not possible either. But a couple of lines below we call it a 'row', and that fits better (imagining the ignorelist as a matrix). > Then I am not convi

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-24 Thread Collin Funk
On 3/24/24 4:05 PM, Bruno Haible wrote: > Oh, indeed. If filetable['added'] and filetable['removed'] are the same, > no wonder that you are seeing nonsense in the .gitignore files... Yes, I didn't notice it because I thought the issue was in my interpretation of the 'sed' and 'join' commands in GL

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-24 Thread Bruno Haible
Collin Funk wrote: > See this decade old typo: > > diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py > index d417137df6..2434e5f506 100644 > --- a/pygnulib/GLImport.py > +++ b/pygnulib/GLImport.py > @@ -1393,7 +1393,7 @@ AC_DEFUN([%s_FILE_LIST], [\n''' % macro_prefix > # Treat

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-24 Thread Collin Funk
On 3/23/24 7:15 PM, Bruno Haible wrote: > :-D Well, that's the principle of a von-Neumann computer: that a program > (consisting of instructions) can assemble other instructions, to form a new > program. For CPU instructions, it's a well-known technique. For 'sed' > programs, apparently not... LOL

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-23 Thread Bruno Haible
Collin Funk wrote: > sed -e 's,/,\\/,g' -e 's,^,/^,' -e 's,$,\$/d,' < "$tmp"/ignore-removed > if test -n "$anchor"; then sed -e 's,/,\\/,g' -e > "s,^,/^${doubly_escaped_anchor}," -e 's,$,$/d,' < "$tmp"/ignore-removed; fi > > Which uses sed expressions to create sed expressions right? Like this: >

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-23 Thread Collin Funk
Hi Bruno, On 3/23/24 3:49 AM, Bruno Haible wrote: > What's still missing, is the handling of 'files_removed'. > GLImport.py lines 804..820 ought to match gnulib-tool.sh lines 6253..6273. Sorry I haven't fixed this yet. I'm pretty sure I have been overthinking this issue for the past hour or two h

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-23 Thread Bruno Haible
Hi Collin, > This patch should hopefully stop gnulib-tool.py from mangling > .gitignore files like it did previously. I think I did a decent job > translating the join calls into Python sets, but any criticism is > welcome. I've applied the patch, although it is incomplete. Next, I applied the a

[PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-22 Thread Collin Funk
0; then Then have something like this in init.sh? I'm not sure if this would also apply to the test directory tests. CollinFrom b163f88f90453f20564960265a3cb5236c33ba85 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Fri, 22 Mar 2024 19:43:41 -0700 Subject: [PATCH] gnulib-tool.py: Follow g