Re: [PATCH] gnulib-tool.py: Fix unconditional Automake snippets for non-tests.

2024-03-22 Thread Bruno Haible
Hi Collin, > filter_filelist will join an empty list. In > GLModule.getAutomakeSnippet_Unconditional we split by the same > separator which results in a list with an empty string. ... which is then (at least once) converted to a set with an empty string and back to a list with an empty string. Pr

Re: [PATCH] gnulib-tool.py: Fix unconditional Automake snippets for non-tests.

2024-03-22 Thread Collin Funk
result = separator.join(listing) +else: +result = '' return result Still not the prettiest code, but maybe I will think of something better later... CollinFrom 8f0946720b61407b5628aeadc224addc71a4dcfe Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Fri, 22 Mar 2024 02:15:

Re: [PATCH] gnulib-tool.py: Fix unconditional Automake snippets for non-tests.

2024-03-21 Thread Collin Funk
Hi Bruno, On 3/21/24 2:26 PM, Bruno Haible wrote: > if extra_files != [''] and extra_files: > if extra_files != ['']: > if buildaux_files != ['']: > > Why does [''] represent the empty set/list here? Is something wrong with the > function filter

Re: [PATCH] gnulib-tool.py: Fix unconditional Automake snippets for non-tests.

2024-03-21 Thread Bruno Haible
Hi Collin, > This patch seems correct to me and allows me to do this for the first > time: > > $ env GNULIB_TOOL_IMPL=sh ./admin/merge-gnulib > $ git add . > $ rm -rf * > $ git restore . > $ env GNULIB_TOOL_IMPL=py ./admin/merge-gnulib > $ git status > On branch master > Your branch is up to date

[PATCH] gnulib-tool.py: Fix unconditional Automake snippets for non-tests.

2024-03-20 Thread Collin Funk
b270840ed6fc3b0c8810589bab5833be Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Wed, 20 Mar 2024 11:57:19 -0700 Subject: [PATCH] gnulib-tool.py: Fix unconditional Automake snippets for non-tests. * pygnulib/GLModuleSystem.py (GLModule.getAutomakeSnippet_Unconditional): Fix the file look