Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-14 Thread Paul Eggert
Bruno Haible wrote: Anything that uses an Automake-specific feature other than "if FOO / else / endif" would be suspect, yes. For example, I suppose there would be trouble if a module uses the Automake syntax "if FOO / else !FOO / endif !FOO". Hmm. We use this pattern a lot. In particular, in ev

Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-13 Thread Bruno Haible
Hi Paul, > Anything that uses an Automake-specific feature other than "if FOO / > else / endif" would be suspect, yes. For example, I suppose there would > be trouble if a module uses the Automake syntax "if FOO / else !FOO / > endif !FOO". Hmm. We use this pattern a lot. In particular, in eve

Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-13 Thread Paul Eggert
On 03/13/2017 02:07 AM, Bruno Haible wrote: Do we need to revisit the Makefile.am section of all modules/* files? Are there anti-patterns that should not be used in modules files when a module should be usable with GNU Make instead of Automake? Anything that uses an Automake-specific feature ot

Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-13 Thread Paul Eggert
On 03/12/2017 11:58 PM, Thien-Thi Nguyen wrote: + if false && $gnu_make; then Typo? Thanks for catching that. It's a harmless typo, as the then-part is not supposed to be executed; this was an alternative implementation I was thinking of doing, but discarded in favor of the "${AUTOCONF}

Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-13 Thread Bruno Haible
Hi Jim, > > the -e option is mandatory anyway when you use sed inside a pipe. > > I was surprised to read the above. What does it mean? > This works with GNU sed and no "-e" option: > > $ echo abc|sed s/b/X/|cat > aXc Oops, thinko. Forget about this sentence. Bruno

Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-13 Thread Jim Meyering
On Mon, Mar 13, 2017 at 2:07 AM, Bruno Haible wrote: > the -e option is mandatory anyway when you use sed inside a pipe. Hi Bruno, I was surprised to read the above. What does it mean? This works with GNU sed and no "-e" option: $ echo abc|sed s/b/X/|cat aXc

Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-13 Thread Bruno Haible
Hi Paul, > This is for applications like GNU Emacs that use GNU Make > features instead of Automake. Wow! A big change done with so little code. Kudos! Do we need to revisit the Makefile.am section of all modules/* files? Are there anti-patterns that should not be used in modules files when a mo

Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-13 Thread Thien-Thi Nguyen
() Paul Eggert () Sun, 12 Mar 2017 19:19:43 -0700 + if false && $gnu_make; then Typo? -- Thien-Thi Nguyen --- (defun responsep (query) (pcase (context query) (`(technical ,ml) (correctp ml)) ...)) 748E

[PATCH] gnulib-tool: new option --gnu-make

2017-03-12 Thread Paul Eggert
This is for applications like GNU Emacs that use GNU Make features instead of Automake. * doc/gnulib-tool.texi (Initial import): Mention --gnu-make. * doc/gnulib.texi (Unit test modules, Build robot for gnulib): Do not assume Automake. * gnulib-tool (func_determine_path_separator) (func_modules_tra