Re: [PATCH] gettext: do not assume '#define ... defined ...' behavior

2012-07-15 Thread Bruno Haible
Hi Paul, > I expect the problem is what happens when you do something > like this: > > #define FOO BAR > #define BAR -0 > #define def defined > #define X def FOO > #if X > > Does this test where FOO is defined, or BAR? Or maybe it > tests neither and just evaluates 0 - 0? A very nice example :

Re: [PATCH] gettext: do not assume '#define ... defined ...' behavior

2012-07-12 Thread Paul Eggert
On 07/12/2012 03:15 AM, Bruno Haible wrote: > I tried it and was surprised to see that all compilers support it. I expect the problem is what happens when you do something like this: #define FOO BAR #define BAR -0 #define def defined #define X def FOO #if X Does this test where FOO is defined, o

Re: [PATCH] gettext: do not assume '#define ... defined ...' behavior

2012-07-12 Thread Bruno Haible
Hi Paul, > Here's a proposed patch to fix a gnulib portability bug uncovered > with gzip 1.5. Thanks, the patch is good. Actually when writing this code, I wondered whether I could use '#define FOO ... defined BAR ...'. Although ISO C 99 6.10.1.(3) explicitly says that it's undefined behaviour:

[PATCH] gettext: do not assume '#define ... defined ...' behavior

2012-07-11 Thread Paul Eggert
Here's a proposed patch to fix a gnulib portability bug uncovered with gzip 1.5. --- ChangeLog |9 + lib/gettext.h |9 ++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index b27ef8d..7dacfb7 100644 --- a/ChangeLog +++ b/ChangeLog