Re: [PATCH] getentropy, getrandom: new modules

2020-05-31 Thread Bruno Haible
Now that we're done with the 'getrandom' module, a fix and a tweak for the 'getentropy' module. 2020-05-31 Bruno Haible getentropy: Enhance tests. * tests/test-getentropy.c (main): Add one more test. * tests/test-unistd-c++.cc: Check the signature of getentropy. 2020-

Re: [PATCH] getentropy, getrandom: new modules

2020-05-30 Thread Paul Eggert
On 5/30/20 5:58 AM, Bruno Haible wrote: > There are several problems with this commit: > - It causes a Continuous Integration failure. > - It partially overlaps with the crypto/gc-random module. > - The ChangeLog entry lists files that were not committed. > - It conflicts with the declarati

Re: [PATCH] getentropy, getrandom: new modules

2020-05-30 Thread Bruno Haible
Now that we have a module with test cases, we see that there is a conflict with the function defined on Solaris 11.3 and newer: ../gllib/sys/random.h: In member function ‘gnulib::_gl_getrandom_wrapper::operator gnulib::_gl_getrandom_wrapper::type() const’: ../gllib/sys/random.h:535:1: error: in

Re: [PATCH] getentropy, getrandom: new modules

2020-05-30 Thread Bruno Haible
On platforms which do have a that does not declare getrandom() - such as Mac OS X 10.5 or HP-UX 11, gnulib should not override the system's , but augment it. Otherwise we hide system functions that the user may want to use. Also, the getrandom() declaration lacks an 'extern "C"' marker in C++ mod

Re: [PATCH] getentropy, getrandom: new modules

2020-05-30 Thread Bruno Haible
The getrandom module produces a Continuous Integration failure, see https://gitlab.com/gnulib/gnulib-ci/-/jobs/574033012 . Namely: In file included from getentropy.c:24:0: ./sys/random.h:8:9: error: conflicting types for 'getrandom' ssize_t getrandom (void *, size_t, unsigned int);

Re: [PATCH] getentropy, getrandom: new modules

2020-05-30 Thread Bruno Haible
There are several problems with this commit: - It causes a Continuous Integration failure. - It partially overlaps with the crypto/gc-random module. - The ChangeLog entry lists files that were not committed. - It conflicts with the declaration on Solaris 11.3 and newer. - It adds a new he

[PATCH] getentropy, getrandom: new modules

2020-05-25 Thread Paul Eggert
* MODULES.html.sh (func_all_modules): * lib/unistd.in.h (getentropy, getrandom): * m4/unistd_h.m4 (gl_UNISTD_H, gl_UNISTD_H_DEFAULTS): * modules/unistd (unistd.h): Add support for getentropy, getrandom. * doc/glibc-functions/getentropy.texi (getentropy): * doc/glibc-functions/getrandom.texi (getran