Re: [PATCH] getaddrinfo: fix gai_strerror signature

2011-04-29 Thread Eric Blake
On 04/29/2011 06:09 AM, Bruno Haible wrote: > Eric Blake wrote: >> +getaddrinfo: fix gai_strerror signature >> +* m4/getaddrinfo.m4 (gl_GETADDRINFO): Detect broken signatures, >> +and work around mingw with UNICODE defined. >> +(gl_PREREQ_GETADDRINFO): Drop redundant decl check. >>

Re: [PATCH] getaddrinfo: fix gai_strerror signature

2011-04-29 Thread Bruno Haible
Eric Blake wrote: > + getaddrinfo: fix gai_strerror signature > + * m4/getaddrinfo.m4 (gl_GETADDRINFO): Detect broken signatures, > + and work around mingw with UNICODE defined. > + (gl_PREREQ_GETADDRINFO): Drop redundant decl check. > + * m4/netdb_h.m4 (gl_NETDB_H_DEFAULTS): Ad

Re: [PATCH] getaddrinfo: fix gai_strerror signature

2011-04-29 Thread Paolo Bonzini
On 04/29/2011 01:34 AM, Eric Blake wrote: Worse, on mingw, if UNICODE is defined, it is defined to return WCHAR*, which means the result is in unicode but an application expecting bytes for characters will only see a one-byte answer. AFAIR, Bruno didn't like introducing special hacks for the mi

Re: [PATCH] getaddrinfo: fix gai_strerror signature

2011-04-29 Thread Simon Josefsson
Eric Blake writes: > Several platforms declare gai_strerror to return char* rather than > const char*. Worse, on mingw, if UNICODE is defined, it is defined > to return WCHAR*, which means the result is in unicode but an > application expecting bytes for characters will only see a one-byte > ans

[PATCH] getaddrinfo: fix gai_strerror signature

2011-04-28 Thread Eric Blake
Several platforms declare gai_strerror to return char* rather than const char*. Worse, on mingw, if UNICODE is defined, it is defined to return WCHAR*, which means the result is in unicode but an application expecting bytes for characters will only see a one-byte answer. * m4/getaddrinfo.m4 (gl_G