Re: [PATCH] fprintf-posix: fix memory leak

2009-12-19 Thread Joel E. Denny
Hi Bruno, On Sat, 19 Dec 2009, Bruno Haible wrote: > On 2009-12-15, we fixed a memory leak in the fprintf replacement. Since it > is quite important to not reintroduce this bug in the future, I'm adding a > unit test against it. Thanks for taking care of all this. Sorry for my slow response.

Re: [PATCH] fprintf-posix: fix memory leak

2009-12-19 Thread Bruno Haible
Hi, On 2009-12-15, we fixed a memory leak in the fprintf replacement. Since it is quite important to not reintroduce this bug in the future, I'm adding a unit test against it. > - Limit the allowed total memory through a setrlimit call > (cf. tests/test-printf-posix2.c). > - Run the test

Re: [PATCH] fprintf-posix: fix memory leak

2009-12-15 Thread Bruno Haible
Hi Joel, > +2009-12-15 Joel E. Denny > + > + fprintf-posix: fix memory leak > + * lib/fprintf.c (fprintf): Free memory allocated by vasnprintf. The fix is obviously correct. But it's good that you ask, because the bug occurs also in 3 other places. Below is what I'm committing. > I ha

[PATCH] fprintf-posix: fix memory leak

2009-12-14 Thread Joel E. Denny
Ok to push this? Sorry, I haven't yet explored how valgrind tests are supposed to be added to gnulib. >From 165ffc9aaa9bfe41a9977a80edf80e830d765ab9 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Tue, 15 Dec 2009 02:43:07 -0500 Subject: [PATCH] fprintf-posix: fix memory lea