Re: [PATCH] file-has-acl: symlinks can have scontext

2024-11-11 Thread Paul Eggert
On 2024-11-11 07:58, Paul Eggert wrote: For the Cygwin issue, I am easily confused by "else" immediately followed by "#endif" or "#else" or "#elif", and so installed the attached further patch which is merely a refactoring. Come to think of it, we also should use acl_get_link_np later in that

Re: [PATCH] file-has-acl: symlinks can have scontext

2024-11-11 Thread Paul Eggert
On 2024-11-10 22:25, Bruno Haible wrote: ../../gllib/file-has-acl.c:427:21: error: 'acl_get_link_np' undeclared (first use in this function) 427 | : acl_get_link_np) | ^~~ Thanks for fixing those bugs. For the Cygwin issue, I am easil

Re: [PATCH] file-has-acl: symlinks can have scontext

2024-11-10 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > + When ! (flags & AC_SYMLINK_FOLLOW), prefer acl_get_link_np to > + acl_get_file on platforms that have both APIs, This patch leads to compilation errors on macOS, FreeBSD, NetBSD, Cygwin: ../../gllib/file-has-acl.c:425:27: error: use of undeclared identifier 'AC_SYM

[PATCH] file-has-acl: symlinks can have scontext

2024-11-09 Thread Paul Eggert
Problem reported by Pádraig Brady . * lib/file-has-acl.c (file_has_aclinfo): With SELinux, symbolic links can have security contexts, so omit incorrect optimizations assuming that they lack them. When ! (flags & AC_SYMLINK_FOLLOW), prefer acl_get_link_np to acl_get_fi