Paul Eggert wrote on 2024-09-30:
> * m4/acl.m4 (gl_FUNC_ACL_ARG): Add --without-libsmack option.
> (gl_FILE_HAS_ACL): Check for libsmack, selinux.
There is a mistake here:
- The only possible values of with_libsmack are empty and 'maybe'.
- Use of --with-libsmack and --without-libsmack has no effe
Paul Eggert wrote:
> > ../../gllib/file-has-acl.c:427:21: error: use of undeclared identifier
> > 'acl_extended_file'
> >? acl_extended_file
>
> Thanks, fixed by installing the attached.
Thanks. The Gnulib CI build is now green again.
Bruno
On 2024-10-01 15:20, Bruno Haible wrote:
Why include ? I see nothing that uses it.
Oh, one of my working versions used it and I forgot to remove it. Thanks
for reporting that. I removed that include.
On 2024-10-01 14:42, Bruno Haible wrote:
../../gllib/file-has-acl.c:427:21: error: use of undeclared identifier
'acl_extended_file'
? acl_extended_file
Thanks, fixed by installing the attached.From 9256d97e074bbae33bbd188e742daccfb72022de Mon Sep 17 00:00:00 2001
From: Paul
Paul Eggert wrote:
> diff --git a/tests/test-file-has-acl.c b/tests/test-file-has-acl.c
> index 1a10286cd2..c076660942 100644
> --- a/tests/test-file-has-acl.c
> +++ b/tests/test-file-has-acl.c
> @@ -22,6 +22,7 @@
>
> #include
> #include
> +#include
> #include
> #include
> #include
>
Paul Eggert wrote:
> I installed the 2nd patch as an optimization discovered after more
> testing with coreutils.
This patch causes another regression: A compilation error on macOS and
NetBSD.
On macOS (12..15):
/Users/runner/work/ci-testdir-check/ci-testdir-check/macos-compile clang
-DHAVE_CO
On 2024-09-30 06:30, Bruno Haible wrote:
Did you mean 152 ? Or maybe 512 ?
I used "152" because that is what file-has-acl previously used. I
installed the first patch to explain this better.
I installed the 2nd patch as an optimization discovered after more
testing with coreutils.
Further
Paul Eggert wrote:
> +char __gl_acl_ch[152];
Did you mean 152 ? Or maybe 512 ?
> gcc -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -DNO_XMALLOC -DEXEEXT=\"\"
> -I. -I../../gllib -I.. -DGNULIB_STRICT_CHECKING=1 -Wall
> -DCONTINUE_AFTER_ASSERT -fvisibility=hidden -g -O2 -MT selinux-at.o -MD -MP
> -MF $depbase.Tpo -c -o selinux-at.o ../../gllib/selinux-at.c &&\
> mv -f $depbas
Hi Paul,
The CI reports that this patch leads to a compilation error on most
platforms. For example, on Alpine Linux:
gcc -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -DNO_XMALLOC -DEXEEXT=\"\" -I.
-I../../gllib -I.. -DGNULIB_STRICT_CHECKING=1 -Wall -DCONTINUE_AFTER_ASSERT
-fvisibility=hidden -
This is for GNU coreutils, whose ‘ls’ can be made faster with the
new function because it means (for example) that ‘ls’ needn’t call
both listxattr and lgetxattr in the common case where the file has
no extended attributes.
* lib/acl.h (ACL_SYMLINK_FOLLOW): New constant.
(struct aclinfo): New type.
11 matches
Mail list logo
