On 5/28/23 11:49, Jim Meyering wrote:
That would also solve the problem, but at a potential code-gen cost,
as you imply: code-gen for a few rare new and modified functions may
end up being degraded. I would endorse this approach if that GCC bug
is still unresolved in say October.
Sounds good to
On Sun, May 28, 2023 at 10:44 AM Bruno Haible wrote:
> How about adding -Wno-suggest-attribute to the list of warning options that
> are part of the GL_CFLAG_GNULIB_WARNINGS variable, no that such warnings
> function might be candidate for attribute 'pure'
> or
> function might be candidate fo
On Sun, May 28, 2023 at 10:08 AM Bruno Haible wrote:
>
> Hi Jim,
>
> Jim Meyering wrote:
> > FYI, just pushed, to avoid this:
> >
> > lib/file-has-acl.c: In function 'have_xattr':
> > lib/file-has-acl.c:54:1: error: function might be candidate for attribute
> > 'pure' if it is known to return
How about adding -Wno-suggest-attribute to the list of warning options that
are part of the GL_CFLAG_GNULIB_WARNINGS variable, no that such warnings
function might be candidate for attribute 'pure'
or
function might be candidate for attribute 'const'
no longer occur in gnulib source files, comp
Hi Jim,
Jim Meyering wrote:
> FYI, just pushed, to avoid this:
>
> lib/file-has-acl.c: In function 'have_xattr':
> lib/file-has-acl.c:54:1: error: function might be candidate for attribute
> 'pure' if it is known to return normally [-Werror=suggest-attribute=pure]
> 54 | have_xattr (cha
char const *listbuf, ssize_t listsize)
>From 2bd4c8dc13de3121d76dad755a255c8e92fd46a7 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 28 May 2023 09:41:08 -0700
Subject: [PATCH] file-has-acl: avoid warning from bleeding-edge GCC
* lib/file-has-acl.c: Include attribute.h.
(have_xattr): Decl
