Re: [PATCH] ensure that the regexp [b-a] is diagnosed as invalid

2010-02-04 Thread Paolo Bonzini
On 02/03/2010 07:22 PM, Jim Meyering wrote: - Revert this patch: ensure that the regexp [b-a] is diagnosed as invalid - Modify the !_LIBC build_range_exp function to take a new argument, syntax, and use that to guard the wcscoll test above. - Ensure that grep uses the

Re: [PATCH] ensure that the regexp [b-a] is diagnosed as invalid

2010-02-03 Thread Jim Meyering
t; 0) return REG_ERANGE; Since I want grep (and any other tool using gnulib's regex) to diagnose out-of-order ranges consistently, not just on x86_64-based and non-glibc systems, I can't leave this as-is. Here's what I'm planning: - Revert this patch: ensur

Re: [PATCH] ensure that the regexp [b-a] is diagnosed as invalid

2010-02-03 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: >> It adds a test to gl_REGEX that ensures that re_compiler_pattern >> diagnoses [b-a] as invalid when using RE_SYNTAX_POSIX_EGREP. > > Where does POSIX state that this is invalid? Thanks for looking. I too verified (before embarking) that P

Re: [PATCH] ensure that the regexp [b-a] is diagnosed as invalid

2010-02-03 Thread Eric Blake
Jim Meyering meyering.net> writes: > It adds a test to gl_REGEX that ensures that re_compiler_pattern > diagnoses [b-a] as invalid when using RE_SYNTAX_POSIX_EGREP. Where does POSIX state that this is invalid? So far, I can only see that it is undefined, but have not found any hard requirement

[PATCH] ensure that the regexp [b-a] is diagnosed as invalid

2010-02-03 Thread Jim Meyering
bug shortly. >From 18f8ae4bbed4d919e564fe54b94feb6bce2c4c8f Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 19 Jan 2010 08:25:12 +0100 Subject: [PATCH] ensure that the regexp [b-a] is diagnosed as invalid * m4/regex.m4 (gl_REGEX): Ensure that re_compiler_pattern diagnoses [b-a