Re: [PATCH] directory separator

2012-06-07 Thread John Darrington
On Thu, Jun 07, 2012 at 12:29:03AM -0700, Paul Eggert wrote: On 06/07/2012 12:19 AM, John Darrington wrote: > Surely using a symbol instead of a literal constant makes maintenance easier not > harder? I don't see why. For example: remove ("a/b");

Re: [PATCH] directory separator

2012-06-07 Thread Paul Eggert
On 06/07/2012 12:19 AM, John Darrington wrote: > Surely using a symbol instead of a literal constant makes maintenance easier > not > harder? I don't see why. For example: remove ("a/b"); is simpler and easier to maintain than: #if DIRECTORY_SEPARATOR == '/' #define DIRECTORY_SEPARAT

Re: [PATCH] directory separator

2012-06-07 Thread John Darrington
On Wed, Jun 06, 2012 at 01:07:41PM -0700, Paul Eggert wrote: On 06/06/2012 12:43 PM, John Darrington wrote: > If as you say, windows prefers \ is there a good reason NOT to use it? Mostly to avoid the maintenance hassle. Surely using a symbol instead of a literal constant mak

Re: [PATCH] directory separator

2012-06-06 Thread Paul Eggert
On 06/06/2012 12:43 PM, John Darrington wrote: > If as you say, windows prefers \ is there a good reason NOT to use it? Mostly to avoid the maintenance hassle. Also, the change makes the code a bit bigger and slower even on non-Windows platforms.

Re: [PATCH] directory separator

2012-06-06 Thread John Darrington
On Wed, Jun 06, 2012 at 01:10:09PM -0600, Eric Blake wrote: On 06/06/2012 12:54 PM, John Darrington wrote: > I'm offering this patch which ensures that the paths of tempfiles are > created with the appropriate separator for the machine. What platform did you need it on?

Re: [PATCH] directory separator

2012-06-06 Thread Eric Blake
On 06/06/2012 12:54 PM, John Darrington wrote: > I'm offering this patch which ensures that the paths of tempfiles are > created with the appropriate separator for the machine. What platform did you need it on? Windows understands paths with /, even if it prefers \ as the canonical separator, an

[PATCH] directory separator

2012-06-06 Thread John Darrington
I'm offering this patch which ensures that the paths of tempfiles are created with the appropriate separator for the machine. J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://keys.gnupg.net or any PGP keyserver for public key.