Re: [PATCH] crypto/md5: don't depend on stdint

2011-02-18 Thread Paul Eggert
On 02/18/2011 03:13 AM, Bruno Haible wrote: 35 lines of code to define a type md5_uint32, that is only used in md5.h? I used 35 lines because that's what glibc uses. I can easily shrink it to 8 lines, since we assume C89 or better: /* Prefer 'unsigned int' for the benefit of typical pre-C99

Re: [PATCH] crypto/md5: don't depend on stdint

2011-02-18 Thread Bruno Haible
Paul Eggert wrote: > Here's a simple patch to remove crypto/md5's dependence on > stdint. It complicates the code in md5.h a bit 35 lines of code to define a type md5_uint32, that is only used in md5.h? That's a step backwards to where we were before gnulib. The benefit of gnulib is that we can p

Re: [PATCH] crypto/md5: don't depend on stdint

2011-02-18 Thread Jim Meyering
Paul Eggert wrote: > Here's a simple patch to remove crypto/md5's dependence on > stdint. It complicates the code in md5.h a bit, but the > result is closer to what's already in glibc. This will > make it quite a bit easier for Emacs to use crypto/md5. > > I haven't pushed this yet. > > * lib/md5

[PATCH] crypto/md5: don't depend on stdint

2011-02-18 Thread Paul Eggert
Here's a simple patch to remove crypto/md5's dependence on stdint. It complicates the code in md5.h a bit, but the result is closer to what's already in glibc. This will make it quite a bit easier for Emacs to use crypto/md5. I haven't pushed this yet. * lib/md5.h, lib/md5.c: All uses of uint32