Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-15 Thread Ben Pfaff
Bruno Haible writes: >> Here is #2. >> Here is #3: > > Perfect. Please push (after rebasing). Thanks. Done. -- Ben Pfaff http://benpfaff.org

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-15 Thread Bruno Haible
Hi Ben, > Here is #2. > Here is #3: Perfect. Please push (after rebasing). Bruno

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-14 Thread Ben Pfaff
Bruno Haible writes: > So, I would propose > 1) to apply the patch below, > 2) to use the common idiom > if test $HAVE_STRTOD = 0 || test $REPLACE_STRTOD = 1; then > like you did above, > 3) to improve the cross-compiling guess. Good ideas. Here is #2. I'll follow up with #3

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-14 Thread Ben Pfaff
Bruno Haible writes: > 1) to apply the patch below, > 2) to use the common idiom > if test $HAVE_STRTOD = 0 || test $REPLACE_STRTOD = 1; then > like you did above, > 3) to improve the cross-compiling guess. Here is #3: >From 60471b91b5dbdf2c24c258640cee6dfdb32c4d6f Mon Sep 17

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-14 Thread Ben Pfaff
Eric Blake writes: > Or even better, why not push those two tests upstream into autoconf, > then have gnulib override AC_FUNC_STRTOD if it detects older autoconf, > so that everyone using upstream AC_FUNC_STRTOD can reliably detect these > same bugs? The strtod() tests that are currently in gl_F

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-14 Thread Eric Blake
On 06/14/2010 12:01 PM, Ben Pfaff wrote: > Eric Blake writes: > >> Or even better, why not push those two tests upstream into autoconf, >> then have gnulib override AC_FUNC_STRTOD if it detects older autoconf, >> so that everyone using upstream AC_FUNC_STRTOD can reliably detect these >> same bug

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-14 Thread Eric Blake
[adding bug-autoconf] On 06/13/2010 05:43 PM, Bruno Haible wrote: > Hi Ben, > >> The problem is that AC_FUNC_STRTOD assumes that strtod does not >> exist when cross-compiling, which in turn makes the strtod module >> assume that it does not need to handle an existing declaration. > > Ah, so AC_F

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-13 Thread Bruno Haible
Hi Ben, > The problem is that AC_FUNC_STRTOD assumes that strtod does not > exist when cross-compiling, which in turn makes the strtod module > assume that it does not need to handle an existing declaration. Ah, so AC_FUNC_STRTOD makes gnulib think that strtod() does not exist, although in fact i

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-13 Thread Ben Pfaff
Bruno Haible writes: >> As you can see, this defines an inline version of strtod() that >> conflicts with the out-of-line version in lib/strtod.c. >> >> Is there an idiomatic solution for this kind of problem? > > Why does it conflict? gnulib's replacement already contains the > idiomatic solut

Re: [PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-11 Thread Bruno Haible
Hi Ben, > Cross-compiling lib/strtod.c failed on Mingw, as reported at > http://savannah.gnu.org/bugs/?29965: > > strtod.c:37: error: redefinition of 'strtod' > /usr/i686-pc-mingw32/sys-root/mingw/include/stdlib.h:319: note: > previous definition of 'strtod' was here > > The problem

[PATCH] bypass broken inline strtod() definition in on Mingw

2010-06-10 Thread Ben Pfaff
ding my fix, which I have not yet pushed out. --8<--cut here-->8-- >From 525a69cbe8d636ac1442aab4c6adb8df09b4b534 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Thu, 10 Jun 2010 21:10:51 -0700 Subject: [PATCH] Bypass broken inline strtod