Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-27 Thread Gary V. Vaughan
Hi Jim, On 28 Jan 2013, at 09:52, Jim Meyering wrote: > Gary V. Vaughan wrote: > ... > so it would be safer to probe for > and use a backslash safe echo here > Much better would be to just use printf. Safer, simpler and more portable! >>> >>> Yes. For uses like this, echo has

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-27 Thread Jim Meyering
Gary V. Vaughan wrote: ... so it would be safer to probe for and use a backslash safe echo here >>> Much better would be to just use printf. Safer, simpler and more portable! >> >> Yes. For uses like this, echo has been deprecated >> for well over a decade. > > And here's another o

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-27 Thread Gary V. Vaughan
Hi Jim, Stefano, Thanks for your comments. On 28 Jan 2013, at 03:07, Jim Meyering wrote: > Stefano Lattarini wrote: >> Throwing in my two cents here ... > ... Stefano, I didn't get a copy of your message for some reason, only Jim's reply :-o >>> $(...) is not supported by even some modern syst

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-27 Thread Jim Meyering
Stefano Lattarini wrote: > Throwing in my two cents here ... ... Thanks. >> $(...) is not supported by even some modern systems, including solaris 10. >> > Actually, only by /bin/sh. Solaris 10 has a working Korn shell in > /bin/ksh and a working POSIX shell in /usr/xpg4/bin/sh. Requiring > a d

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-27 Thread Gary V. Vaughan
Hi Padraig, On 26 Jan 2013, at 21:39, Pádraig Brady wrote: > Thanks for the review and tips Gary. Welcome, and likewise for yours :) > While I noticed some of those I didn't fix because > those styles/issues were already used (elsewhere) in bootstrap. Unfortunately so :( > Addressing them are

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-26 Thread Pádraig Brady
On 01/26/2013 05:27 AM, Gary V. Vaughan wrote: Hi Bernhard, Padraig, Sorry for the late review, I didn't notice this until after the push notification. Comments interspersed below... On 21 Jan 2013, at 02:20, Bernhard Voelker wrote: During bootstrap, files may be created which are already in

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-26 Thread Stefano Lattarini
Throwing in my two cents here ... On 01/26/2013 06:27 AM, Gary V. Vaughan wrote: > Hi Bernhard, Padraig, > > Sorry for the late review, I didn't notice this until after the push > notification. Comments interspersed below... > > On 21 Jan 2013, at 02:20, Bernhard Voelker wrote: >> During boots

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-25 Thread Gary V. Vaughan
Hi Bernhard, Padraig, Sorry for the late review, I didn't notice this until after the push notification. Comments interspersed below... On 21 Jan 2013, at 02:20, Bernhard Voelker wrote: > During bootstrap, files may be created which are already included > in .gitignore, but the test to add such

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-25 Thread Pádraig Brady
On 01/20/2013 07:20 PM, Bernhard Voelker wrote: During bootstrap, files may be created which are already included in .gitignore, but the test to add such a file relied on the sort order. Now, it just adds such a new entry and thus only changes the file if the line count would change. * bootstra

[PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-20 Thread Bernhard Voelker
During bootstrap, files may be created which are already included in .gitignore, but the test to add such a file relied on the sort order. Now, it just adds such a new entry and thus only changes the file if the line count would change. * bootstrap (insert_if_absent): Instead of comparing the sor